Implementation can be improved a bit.
Created attachment 336979 [details] Patch
Comment on attachment 336979 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336979&action=review Nice > Source/WebCore/platform/text/enchant/TextCheckerEnchant.cpp:43 > + if (!dictionary) > + return; Remember C++ guarantees this func is only called if the parameter is nonnull, so remove this.
(In reply to Michael Catanzaro from comment #2) > Comment on attachment 336979 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=336979&action=review > > Nice > > > Source/WebCore/platform/text/enchant/TextCheckerEnchant.cpp:43 > > + if (!dictionary) > > + return; > > Remember C++ guarantees this func is only called if the parameter is > nonnull, so remove this. Ah, right!
Committed r230198: <https://trac.webkit.org/changeset/230198>
<rdar://problem/39133084>