Bug 184233 - [Enchant] Clean up TextCheckerEnchant
Summary: [Enchant] Clean up TextCheckerEnchant
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, InRadar
Depends on: 183738
Blocks:
  Show dependency treegraph
 
Reported: 2018-04-02 05:49 PDT by Carlos Garcia Campos
Modified: 2018-04-03 00:18 PDT (History)
3 users (show)

See Also:


Attachments
Patch (16.20 KB, patch)
2018-04-02 05:57 PDT, Carlos Garcia Campos
mcatanzaro: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2018-04-02 05:49:25 PDT
Implementation can be improved a bit.
Comment 1 Carlos Garcia Campos 2018-04-02 05:57:47 PDT
Created attachment 336979 [details]
Patch
Comment 2 Michael Catanzaro 2018-04-02 08:02:31 PDT
Comment on attachment 336979 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336979&action=review

Nice

> Source/WebCore/platform/text/enchant/TextCheckerEnchant.cpp:43
> +    if (!dictionary)
> +        return;

Remember C++ guarantees this func is only called if the parameter is nonnull, so remove this.
Comment 3 Carlos Garcia Campos 2018-04-02 08:22:47 PDT
(In reply to Michael Catanzaro from comment #2)
> Comment on attachment 336979 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=336979&action=review
> 
> Nice
> 
> > Source/WebCore/platform/text/enchant/TextCheckerEnchant.cpp:43
> > +    if (!dictionary)
> > +        return;
> 
> Remember C++ guarantees this func is only called if the parameter is
> nonnull, so remove this.

Ah, right!
Comment 4 Carlos Garcia Campos 2018-04-03 00:16:57 PDT
Committed r230198: <https://trac.webkit.org/changeset/230198>
Comment 5 Radar WebKit Bug Importer 2018-04-03 00:18:20 PDT
<rdar://problem/39133084>