Bug 184233 – [Enchant] Clean up TextCheckerEnchant

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Carlos Garcia Campos]

Implementation can be improved a bit.

[Carlos Garcia Campos]

Created attachment 336979 [details]
Patch

[Michael Catanzaro]

Comment on attachment 336979 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336979&action=review

Nice

> Source/WebCore/platform/text/enchant/TextCheckerEnchant.cpp:43
> +    if (!dictionary)
> +        return;

Remember C++ guarantees this func is only called if the parameter is nonnull, so remove this.

[Carlos Garcia Campos]

(In reply to Michael Catanzaro from comment #2)
> Comment on attachment 336979 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=336979&action=review
> 
> Nice
> 
> > Source/WebCore/platform/text/enchant/TextCheckerEnchant.cpp:43
> > +    if (!dictionary)
> > +        return;
> 
> Remember C++ guarantees this func is only called if the parameter is
> nonnull, so remove this.

Ah, right!

[Carlos Garcia Campos]

Committed r230198: <https://trac.webkit.org/changeset/230198>

[Radar WebKit Bug Importer]

<rdar://problem/39133084>