Bug 183738 - [GTK] Segfaults in enchant_broker_free_dict()
Summary: [GTK] Segfaults in enchant_broker_free_dict()
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 184233
  Show dependency treegraph
Reported: 2018-03-19 01:39 PDT by Cédric Bellegarde
Modified: 2018-04-03 00:11 PDT (History)
3 users (show)

See Also:

Backtrace (10.33 KB, text/plain)
2018-03-19 01:39 PDT, Cédric Bellegarde
no flags Details
Patch (2.84 KB, patch)
2018-04-02 04:06 PDT, Carlos Garcia Campos
mcatanzaro: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cédric Bellegarde 2018-03-19 01:39:31 PDT
Created attachment 336035 [details]

Fedora 28 / WebKitGTK 2.20
Comment 1 Michael Catanzaro 2018-03-19 16:42:22 PDT
Are you able to reproduce this one in eolie, or was it random?
Comment 2 Carlos Garcia Campos 2018-04-02 04:04:38 PDT
My guess is that there aren't any dictionaries in the system and m_enchantDictionaries contains a single element that is nullptr, because enchant_broker_request_dict() can return NULL and we ar enot checking it.
Comment 3 Carlos Garcia Campos 2018-04-02 04:06:31 PDT
Created attachment 336977 [details]
Comment 4 Cédric Bellegarde 2018-04-02 06:24:59 PDT
There are dictionnaries on the system but enchant_broker_request_dict() may have return null.
Comment 5 Michael Catanzaro 2018-04-02 07:45:39 PDT
Comment on attachment 336977 [details]

Good catch. This one had stumped me.
Comment 6 Carlos Garcia Campos 2018-04-03 00:11:15 PDT
Committed r230197: <https://trac.webkit.org/changeset/230197>