WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
184190
WorkQueueWin: don't move rvalues
https://bugs.webkit.org/show_bug.cgi?id=184190
Summary
WorkQueueWin: don't move rvalues
JF Bastien
Reported
2018-03-30 13:05:11 PDT
As part of #184167 optional is now more frequently an rvalue reference, and moving its .value() is not a thing that should be done anymore.
Attachments
patch
(2.04 KB, patch)
2018-03-30 13:07 PDT
,
JF Bastien
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2018-03-30 13:05:41 PDT
<
rdar://problem/39049850
>
JF Bastien
Comment 2
2018-03-30 13:07:51 PDT
Created
attachment 336883
[details]
patch Fixes a Windows build failure (because the file is Windows specific).
Mark Lam
Comment 3
2018-03-30 13:09:08 PDT
Comment on
attachment 336883
[details]
patch r=me
WebKit Commit Bot
Comment 4
2018-03-30 13:47:03 PDT
Comment on
attachment 336883
[details]
patch Clearing flags on attachment: 336883 Committed
r230116
: <
https://trac.webkit.org/changeset/230116
>
WebKit Commit Bot
Comment 5
2018-03-30 13:47:05 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug