Bug 184190 - WorkQueueWin: don't move rvalues
Summary: WorkQueueWin: don't move rvalues
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: JF Bastien
URL:
Keywords: InRadar
Depends on: 184167
Blocks:
  Show dependency tree / graph
 
Reported: 2018-03-30 13:05 PDT by JF Bastien
Modified: 2018-03-30 13:47 PDT (History)
11 users (show)

See Also:

Attachments
patch (2.04 KB, patch)
2018-03-30 13:07 PDT, JF Bastien 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description JF Bastien 2018-03-30 13:05:11 PDT 
As part of #184167 optional is now more frequently an rvalue reference, and moving its .value() is not a thing that should be done anymore.
Comment 1 Radar WebKit Bug Importer 2018-03-30 13:05:41 PDT 
<rdar://problem/39049850>
Comment 2 JF Bastien 2018-03-30 13:07:51 PDT 
Created attachment 336883 [details]
patch

Fixes a Windows build failure (because the file is Windows specific).
Comment 3 Mark Lam 2018-03-30 13:09:08 PDT 
Comment on attachment 336883 [details]
patch

r=me
Comment 4 WebKit Commit Bot 2018-03-30 13:47:03 PDT 
Comment on attachment 336883 [details]
patch

Clearing flags on attachment: 336883

Committed r230116: <https://trac.webkit.org/changeset/230116>
Comment 5 WebKit Commit Bot 2018-03-30 13:47:05 PDT 
All reviewed patches have been landed.  Closing bug.