Bug 184167 – Remove CXX_REFERENCE_QUALIFIED_FUNCTIONS

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Template Framework

[JF Bastien]

Remove COMPILER_SUPPORTS(CXX_REFERENCE_QUALIFIED_FUNCTIONS), it's supported by all compilers WebKit supports (it's a C++11 feature, *detection* of it with __has_extension was added to clang on May 13th 2011, and VS2015 / GCC support it).

[Radar WebKit Bug Importer]

<rdar://problem/39023130>

[JF Bastien]

Created attachment 336829 [details]
patch

[Yusuke Suzuki]

Comment on attachment 336829 [details]
patch

Let's enable Optional.h's OPTIONAL_HAS_MOVE_ACCESSORS too!

[JF Bastien]

Created attachment 336837 [details]
patch for landing

[WebKit Commit Bot]

Comment on attachment 336837 [details]
patch for landing

Rejecting attachment 336837 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 336837, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
d at 1 with fuzz 3.
patching file Source/WTF/wtf/Compiler.h
patching file Source/WTF/wtf/Optional.h
patching file Source/WTF/wtf/Ref.h
patching file Source/WTF/wtf/RefPtr.h
patching file Source/WTF/wtf/text/WTFString.cpp
patching file Source/WTF/wtf/text/WTFString.h
Hunk #1 FAILED at 299.
1 out of 1 hunk FAILED -- saving rejects to file Source/WTF/wtf/text/WTFString.h.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/7143574

[JF Bastien]

Created attachment 336838 [details]
patch for landing, rebased onto my other patch which touched WTFString.h

[WebKit Commit Bot]

Comment on attachment 336838 [details]
patch for landing, rebased onto my other patch which touched WTFString.h

Rejecting attachment 336838 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
urces/UnifiedSource15.cpp -o /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/UnifiedSource15.o

** BUILD FAILED **


The following build commands failed:
	CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/UnifiedSource2.o /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource2.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)

Full output: http://webkit-queues.webkit.org/results/7143638

[JF Bastien]

Interesting, the change makes some things rvalue references instead of lvalues, which causes some static asserts. Will fix tomorrow.

[JF Bastien]

Created attachment 336871 [details]
patch

[WebKit Commit Bot]

Comment on attachment 336871 [details]
patch

Rejecting attachment 336871 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
urces/UnifiedSource15.cpp -o /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/UnifiedSource15.o

** BUILD FAILED **


The following build commands failed:
	CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/UnifiedSource2.o /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource2.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)

Full output: http://webkit-queues.webkit.org/results/7149511

[JF Bastien]

Created attachment 336874 [details]
patch

Fix more bad moves. My local build is borked, starting it from scratch so I'm not sure I got all of them yet...

[WebKit Commit Bot]

Comment on attachment 336874 [details]
patch

Clearing flags on attachment: 336874

Committed r230113: <https://trac.webkit.org/changeset/230113>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.