RESOLVED FIXED 183670
BuildbotBuildEntry creates an incorrect url for pending builds 
https://bugs.webkit.org/show_bug.cgi?id=183670
Summary BuildbotBuildEntry creates an incorrect url for pending builds
Aakash Jain
Reported 2018-03-15 11:28:37 PDT
Buildbot 0.9 (and onwards) have a URL for pending builds as well. https://bugs.webkit.org/show_bug.cgi?id=183194 switched from using Buildbot generated buildrequestid to our own build-request-id. Because of this, now the URL we generate is incorrect. The URL for pending builds need the buildrequestid generated by the Buildbot. We should fix this.
Attachments
Proposed patch (2.86 KB, patch)
2018-03-15 11:37 PDT, Aakash Jain 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2018-03-15 11:37:56 PDT
Created attachment 335870 [details] Proposed patch
dewei_zhu
Comment 2 2018-03-15 20:32:59 PDT
Looks good to me.
Aakash Jain
Comment 3 2018-03-16 16:51:05 PDT
Committed r229687: <https://trac.webkit.org/changeset/229687>
Radar WebKit Bug Importer
Comment 4 2018-03-16 16:52:26 PDT
<rdar://problem/38564805>
Note You need to log in before you can comment on or make changes to this bug.