Bug 183670 - BuildbotBuildEntry creates an incorrect url for pending builds
Summary: BuildbotBuildEntry creates an incorrect url for pending builds
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
Keywords: InRadar
Depends on:
Reported: 2018-03-15 11:28 PDT by Aakash Jain
Modified: 2018-03-16 16:52 PDT (History)
6 users (show)

See Also:

Proposed patch (2.86 KB, patch)
2018-03-15 11:37 PDT, Aakash Jain
rniwa: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2018-03-15 11:28:37 PDT
Buildbot 0.9 (and onwards) have a URL for pending builds as well. https://bugs.webkit.org/show_bug.cgi?id=183194 switched from using Buildbot generated buildrequestid to our own build-request-id. Because of this, now the URL we generate is incorrect. The URL for pending builds need the buildrequestid generated by the Buildbot. We should fix this.
Comment 1 Aakash Jain 2018-03-15 11:37:56 PDT
Created attachment 335870 [details]
Proposed patch
Comment 2 dewei_zhu 2018-03-15 20:32:59 PDT
Looks good to me.
Comment 3 Aakash Jain 2018-03-16 16:51:05 PDT
Committed r229687: <https://trac.webkit.org/changeset/229687>
Comment 4 Radar WebKit Bug Importer 2018-03-16 16:52:26 PDT