Bug 183194 – BuildbotBuildEntry for buildbot 0.9 uses incorrect buildrequestid

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

Buildbot 0.9 has a property named 'buildrequestid'. Also perf syncing script set a build property named 'build-request-id'. Both these properties looks very similar in name but have very different purpose. 

https://trac.webkit.org/browser/webkit/trunk/Websites/perf.webkit.org/tools/js/buildbot-syncer.js#L18 uses 'buildrequestid' provided by buildbot. This is not what we want. We want to fetch the 'build-request-id' set by us in the properties.

We should correct BuildbotBuildEntry to use the right variable. Also, we should also rename 'build-request-id' to something else to avoid confusion in future.

[Aakash Jain]

The issue is with pending build-requests. Buildbot API for buildrequests doesn't provide properties. We need to figure out a solution to that first.

[Aakash Jain]

> The issue is with pending build-requests. Buildbot API for buildrequests doesn't provide properties. We need to figure out a solution to that first.
Buildbot API now provides the properties for build-requests after the fix in https://github.com/buildbot/buildbot/pull/3976

[Aakash Jain]

Created attachment 334982 [details]
Patch - WIP

[Aakash Jain]

Created attachment 335060 [details]
Proposed patch

Tested using unit-test. Will test by running syncing scripts as well. Please review meanwhile.

[Ryosuke Niwa]

Comment on attachment 335060 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335060&action=review

> Websites/perf.webkit.org/tools/js/buildbot-syncer.js:24
> +        this._buildRequestId = rawData['properties'] && rawData['properties'][syncer._buildRequestPropertyName] ?
> +                                   rawData['properties'][syncer._buildRequestPropertyName][0] : null;

Nit: Wrong indentation. '?' should be on line 24, and '?' should appear exactly 4 spaces to the right of this._buildRequestId.

[Aakash Jain]

Created attachment 335468 [details]
Patch for landing

Also passed workerName parameter to samplePendingBuildRequestData, instead of hard-coding worker name inside this sample data. This matches with samplePendingBuildRequestDeprecated.

[Aakash Jain]

Committed r229489: <https://trac.webkit.org/changeset/229489>

[Radar WebKit Bug Importer]

<rdar://problem/38397677>

[Radar WebKit Bug Importer]

<rdar://problem/38397676>