Bug 183486 - WPE and GTK builds fail after moving WebCookieManager from WebProcess to NetworkProcess
Summary: WPE and GTK builds fail after moving WebCookieManager from WebProcess to Netw...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: All Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 183382
Blocks:
  Show dependency treegraph
 
Reported: 2018-03-08 16:42 PST by Brent Fulgham
Modified: 2018-03-08 17:04 PST (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2018-03-08 16:42:24 PST
WPE (and GTK) Failure looks like this:

[668/857] Linking CXX executable bin/WPENetworkProcess
FAILED: bin/WPENetworkProcess 
: && /usr/lib/ccache/c++   -fdiagnostics-color=always -Wno-attributes -Wno-maybe-uninitialized -Wwrite-strings -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align -Wextra -Wall  -fno-strict-aliasing -fno-exceptions -std=c++14 -fno-rtti -O3 -DNDEBUG  -L/home/buildbot/wpe/wpe-linux-64-release/build/WebKitBuild/DependenciesWPE/Root/lib -fuse-ld=gold -Wl,--disable-new-dtags Source/WebKit/CMakeFiles/NetworkProcess.dir/NetworkProcess/EntryPoint/unix/NetworkProcessMain.cpp.o  -o bin/WPENetworkProcess  -Wl,-rpath,/home/buildbot/wpe/wpe-linux-64-release/build/WebKitBuild/Release/lib: -rdynamic lib/libWPEWebKit.so.1.0.0 lib/libWebCore.a lib/libPAL.a lib/libJavaScriptCore.a lib/libWTF.a lib/libbmalloc.a -ldl  ../DependenciesWPE/Root/lib/libWPEBackend.so && :
lib/libWPEWebKit.so.1.0.0: error: undefined reference to 'non-virtual thunk to WebKit::WebCookieManager::didReceiveMessage(IPC::Connection&, IPC::Decoder&)'
lib/libWPEWebKit.so.1.0.0: error: undefined reference to 'WebKit::WebCookieManager::didReceiveMessage(IPC::Connection&, IPC::Decoder&)'

The WebCookieManager message handling doesn't seem to be getting generated, even though it appears in the CMakeLists.txt and SourcesWPE.txt/SourcesGTK.txt files.
Comment 1 Brent Fulgham 2018-03-08 16:44:09 PST
See <https://build.webkit.org/builders/WPE%20Linux%2064-bit%20Release%20%28Build%29/builds/9314> for a build failure log.
Comment 2 Brent Fulgham 2018-03-08 17:02:43 PST
This was fixed here:

Committed r229442: <https://trac.webkit.org/changeset/229442>
Comment 3 Radar WebKit Bug Importer 2018-03-08 17:04:19 PST
<rdar://problem/38283714>