Bug 183379 - REGRESSION(r229330): Broke some Apple internal code (Requested by ap on #webkit).
Summary: REGRESSION(r229330): Broke some Apple internal code (Requested by ap on #webk...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Commit Bot
URL:
Keywords: InRadar
Depends on:
Blocks: 183369
  Show dependency treegraph
 
Reported: 2018-03-06 12:49 PST by WebKit Commit Bot
Modified: 2018-03-08 09:08 PST (History)
3 users (show)

See Also:


Attachments
ROLLOUT of r229330 (3.42 KB, patch)
2018-03-06 12:49 PST, WebKit Commit Bot
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Commit Bot 2018-03-06 12:49:25 PST
https://trac.webkit.org/changeset/229330 broke the build:
Broke some Apple internal code (Requested by ap on #webkit).

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.
Comment 1 WebKit Commit Bot 2018-03-06 12:49:31 PST
Created attachment 335127 [details]
ROLLOUT of r229330

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 WebKit Commit Bot 2018-03-06 12:53:57 PST
Comment on attachment 335127 [details]
ROLLOUT of r229330

Rejecting attachment 335127 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 335127, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
e too many unreachable loose objects; run 'git prune' to remove them.

Current branch master is up to date.
Auto packing the repository in background for optimum performance.
See "git help gc" for manual housekeeping.
error: The last gc run reported the following. Please correct the root cause
and remove /Volumes/Data/EWS/WebKit/.git/gc.log.
Automatic cleanup will not be performed until the file is removed.

warning: There are too many unreachable loose objects; run 'git prune' to remove them.


Full output: http://webkit-queues.webkit.org/results/6830281
Comment 3 WebKit Commit Bot 2018-03-06 13:35:15 PST
Comment on attachment 335127 [details]
ROLLOUT of r229330

Rejecting attachment 335127 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 335127, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
patching file Source/WTF/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WTF/wtf/Assertions.cpp
Hunk #1 FAILED at 251.
Hunk #2 succeeded at 338 with fuzz 1 (offset 46 lines).
1 out of 2 hunks FAILED -- saving rejects to file Source/WTF/wtf/Assertions.cpp.rej
patching file Source/WTF/wtf/Assertions.h
Hunk #1 succeeded at 204 with fuzz 2 (offset 4 lines).

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/6830815
Comment 4 Alexey Proskuryakov 2018-03-06 13:43:17 PST
This did get landed in https://trac.webkit.org/r229338, despite the errors logged.
Comment 5 Radar WebKit Bug Importer 2018-03-08 09:08:40 PST
<rdar://problem/38265318>
Comment 6 Radar WebKit Bug Importer 2018-03-08 09:08:42 PST
<rdar://problem/38265319>