Bug 183369 - Remove unused crash hook functionality
Summary: Remove unused crash hook functionality
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords: InRadar
Depends on: 183379
Blocks:
  Show dependency treegraph
 
Reported: 2018-03-06 08:28 PST by Michael Catanzaro
Modified: 2018-04-12 11:56 PDT (History)
11 users (show)

See Also:


Attachments
Patch (3.43 KB, patch)
2018-03-06 08:29 PST, Michael Catanzaro
no flags Details | Formatted Diff | Diff
Patch for landing (3.40 KB, patch)
2018-04-12 11:17 PDT, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2018-03-06 08:28:24 PST
WTFSetCrashHook and WTFInstallReportBacktraceOnCrashHook are not used on any platforms
Comment 1 Michael Catanzaro 2018-03-06 08:29:36 PST
Created attachment 335099 [details]
Patch
Comment 2 Michael Catanzaro 2018-03-06 11:11:01 PST
Committed r229330: <https://trac.webkit.org/changeset/229330>
Comment 3 Radar WebKit Bug Importer 2018-03-06 11:11:22 PST
<rdar://problem/38186660>
Comment 4 Alexey Proskuryakov 2018-03-06 12:48:49 PST
Turns out that these are still used by some Apple internal code. Filed rdar://problem/38190507 to remove the dependency, rolling back for now.
Comment 5 WebKit Commit Bot 2018-03-06 12:49:27 PST
Re-opened since this is blocked by bug 183379
Comment 6 Michael Catanzaro 2018-03-06 14:26:55 PST
Hardly a big deal, but I'm a bit surprised because the crash hook is only ever used in debug builds on Darwin. My guess is that something (Safari?) is installing a nonfunctional crash hook, perhaps?

(Maybe we should consider renaming the *_EXPORT_PRIVATE macros, since they actually make the symbols public.)
Comment 7 Alexey Proskuryakov 2018-04-12 10:47:49 PDT
I think that this can be re-landed now.
Comment 8 Michael Catanzaro 2018-04-12 11:14:09 PDT
Okidokie then.
Comment 9 Michael Catanzaro 2018-04-12 11:17:17 PDT
Created attachment 337810 [details]
Patch for landing
Comment 10 WebKit Commit Bot 2018-04-12 11:56:35 PDT
Comment on attachment 337810 [details]
Patch for landing

Clearing flags on attachment: 337810

Committed r230589: <https://trac.webkit.org/changeset/230589>
Comment 11 WebKit Commit Bot 2018-04-12 11:56:37 PDT
All reviewed patches have been landed.  Closing bug.