Bug 183373 - [Web Animations] Add a new CSSTransition subclass of WebAnimation
Summary: [Web Animations] Add a new CSSTransition subclass of WebAnimation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on: 183371
Blocks:
  Show dependency treegraph
 
Reported: 2018-03-06 09:10 PST by Antoine Quint
Modified: 2018-03-06 13:27 PST (History)
3 users (show)

See Also:


Attachments
Patch (14.91 KB, patch)
2018-03-06 10:38 PST, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch (15.38 KB, patch)
2018-03-06 11:26 PST, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch for landing (15.38 KB, patch)
2018-03-06 12:51 PST, Antoine Quint
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2018-03-06 09:10:30 PST
As we implement CSS Transitions over the Web Animations engine, we’ll need a way to represent an animation created using CSS Transitions. To do so, we’ll add a new CSSTransition subclass of WebAnimation. This Radar covers the basic task of adding the new class to WebCore.
Comment 1 Antoine Quint 2018-03-06 09:10:46 PST
<rdar://problem/38181985>
Comment 2 Antoine Quint 2018-03-06 10:38:14 PST
Created attachment 335114 [details]
Patch
Comment 3 Dean Jackson 2018-03-06 10:40:56 PST
Comment on attachment 335114 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335114&action=review

> Source/WebCore/animation/CSSTransition.cpp:40
> +    auto& document = target.document();
> +
> +    auto result = adoptRef(*new CSSTransition(document));
> +
> +    return result;

Same comment as the other patch.

> Source/WebCore/animation/CSSTransition.h:50
> +    CSSPropertyID m_transitionProperty;
> +
> +};

Extra blank line
Comment 4 Antoine Quint 2018-03-06 11:26:27 PST
Created attachment 335118 [details]
Patch
Comment 5 Antoine Quint 2018-03-06 12:51:28 PST
Created attachment 335128 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2018-03-06 13:27:08 PST
Comment on attachment 335128 [details]
Patch for landing

Clearing flags on attachment: 335128

Committed r229340: <https://trac.webkit.org/changeset/229340>
Comment 7 WebKit Commit Bot 2018-03-06 13:27:09 PST
All reviewed patches have been landed.  Closing bug.