Bug 183373 – [Web Animations] Add a new CSSTransition subclass of WebAnimation

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Antoine Quint]

As we implement CSS Transitions over the Web Animations engine, we’ll need a way to represent an animation created using CSS Transitions. To do so, we’ll add a new CSSTransition subclass of WebAnimation. This Radar covers the basic task of adding the new class to WebCore.

[Antoine Quint]

<rdar://problem/38181985>

[Antoine Quint]

Created attachment 335114 [details]
Patch

[Dean Jackson]

Comment on attachment 335114 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335114&action=review

> Source/WebCore/animation/CSSTransition.cpp:40
> +    auto& document = target.document();
> +
> +    auto result = adoptRef(*new CSSTransition(document));
> +
> +    return result;

Same comment as the other patch.

> Source/WebCore/animation/CSSTransition.h:50
> +    CSSPropertyID m_transitionProperty;
> +
> +};

Extra blank line

[Antoine Quint]

Created attachment 335118 [details]
Patch

[Antoine Quint]

Created attachment 335128 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 335128 [details]
Patch for landing

Clearing flags on attachment: 335128

Committed r229340: <https://trac.webkit.org/changeset/229340>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.