As we implement CSS Animations over the Web Animations engine, we’ll need a way to represent an animation created using CSS Animations. To do so, we’ll add a new CSSAnimation subclass of WebAnimation. This Radar covers the basic task of adding the new class to WebCore.
<rdar://problem/38181724>
Created attachment 335101 [details] Patch
Created attachment 335104 [details] Patch
Attachment 335104 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:21: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 335104 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335104&action=review > Source/WebCore/animation/CSSAnimation.cpp:40 > + auto& document = target.document(); > + > + auto result = adoptRef(*new CSSAnimation(document)); > + > + return result; why not just return adoptRef(*new CSSAnimation(target.document()); > Source/WebCore/animation/CSSAnimation.h:42 > + const String& animationName() const { return m_animationName; } You have no way to set the animation name yet.
(In reply to Dean Jackson from comment #5) > Comment on attachment 335104 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=335104&action=review > > > Source/WebCore/animation/CSSAnimation.cpp:40 > > + auto& document = target.document(); > > + > > + auto result = adoptRef(*new CSSAnimation(document)); > > + > > + return result; > > why not just return adoptRef(*new CSSAnimation(target.document()); > > > Source/WebCore/animation/CSSAnimation.h:42 > > + const String& animationName() const { return m_animationName; } > > You have no way to set the animation name yet. Indeed, this is just setting the stage for future patches where we'll be adding more code to CSSAnimation::create().
Committed r229327: <https://trac.webkit.org/changeset/229327>