Bug 183250 - wkbi is importing some bugs twice
Summary: wkbi is importing some bugs twice
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Safari 11
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lucas Forschler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-01 11:18 PST by Lucas Forschler
Modified: 2018-03-01 12:03 PST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Forschler 2018-03-01 11:18:51 PST
Using this as my tracking bug.
Comment 1 Radar WebKit Bug Importer 2018-03-01 11:19:46 PST
<rdar://problem/38033914>
Comment 3 Lucas Forschler 2018-03-01 11:26:34 PST
This bug wasn't duplicated.
Looking at logs of the other two... it appears we called migrate-bugs twice in a row. I'm not sure why.
Comment 4 Lucas Forschler 2018-03-01 11:32:39 PST
for 183218, here is what I think happened:

Looking at history:
wilander@apple.com	2018-02-28 11:09:25 PST	CC		webkit-bug-importer@group.apple.com
wilander@apple.com	2018-02-28 11:09:28 PST	Assignee	webkit-unassigned@lists.webkit.org	wilander@apple.com
webkit-bug-importer@group.apple.com	2018-02-28 11:09:54 PST	Keywords		InRadar

see the importer was CC'd at 11:09:25 , and then another change was made to the bug (at 11:09:28) before the "InRadar" keyword made it back into Bugzilla (11:09:54).
Comment 5 Lucas Forschler 2018-03-01 11:33:25 PST
the same thing happened to 183249:
wilander@apple.com	2018-03-01 11:04:10 PST	CC		webkit-bug-importer@group.apple.com
wilander@apple.com	2018-03-01 11:04:19 PST	Assignee	webkit-unassigned@lists.webkit.org	wilander@apple.com
webkit-bug-importer@group.apple.com	2018-03-01 11:04:38 PST	Keywords		InRadar
Comment 6 Lucas Forschler 2018-03-01 11:34:12 PST
It looks like there is a race condition. If a bug is modified after CC'ing the importer, but before we get the InRadar keyword, we span another update attempt.
Comment 7 Lucas Forschler 2018-03-01 11:36:42 PST
I'm not sure the best way to address this. We could consider a 'settle timer', to give bugzilla a chance to catch up before processing again.
Comment 8 John Wilander 2018-03-01 12:03:44 PST
I had a feeling it was some kind of race condition. I typically do it that way — CC the importer, then assign the bug to myself.