Bug 183160 - Avoid scheduling a new build request when there are pending builds
Summary: Avoid scheduling a new build request when there are pending builds
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Perf Dashboard (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 175969
  Show dependency tree / graph
 
Reported: 2018-02-26 22:44 PST by Ryosuke Niwa
Modified: 2018-03-04 10:02 PST (History)
7 users (show)

See Also:

Attachments
Works around buildbot 0.9 limitation (4.18 KB, patch)
2018-02-26 22:52 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2018-02-26 22:44:42 PST 
For buildbot 0.9 compatibility, we shouldn't schedule a new build when there are pending build requests on a builder.
Comment 1 Ryosuke Niwa 2018-02-26 22:52:06 PST 
Created attachment 334673 [details]
Works around buildbot 0.9 limitation
Comment 2 Aakash Jain 2018-02-27 08:23:28 PST 
Comment on attachment 334673 [details]
Works around buildbot 0.9 limitation

Looks good. Thanks for the patch.
Comment 3 Aakash Jain 2018-02-27 19:16:45 PST 
Please hold-off from committing it. This might not solve all the problem. We still need properties for pending build in order to get build-request-id. So, we might have to fix the root-cause of buildbot not providing us the properties.

See https://bugs.webkit.org/show_bug.cgi?id=183194
Comment 4 Ryosuke Niwa 2018-02-28 01:47:02 PST 
(In reply to Aakash Jain from comment #3)
> Please hold-off from committing it. This might not solve all the problem. We
> still need properties for pending build in order to get build-request-id.
> So, we might have to fix the root-cause of buildbot not providing us the
> properties.
> 
> See https://bugs.webkit.org/show_bug.cgi?id=183194

Oh, that's a good point. Otherwise, we won't be able to update the perf dashboard when we've scheduled a build.
Comment 5 Aakash Jain 2018-03-04 10:02:55 PST 
> So, we might have to fix the root-cause of buildbot not providing us the properties.
Buildbot API now provides the properties for build-requests after the fix in https://github.com/buildbot/buildbot/pull/3976