Bug 182996 - [GStreamer] We need to adopt GstGlDisplays after GStreamer 1.13.1
Summary: [GStreamer] We need to adopt GstGlDisplays after GStreamer 1.13.1
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL: https://bugzilla.gnome.org/show_bug.c...
Keywords: InRadar
Depends on: 182968
  Show dependency treegraph
Reported: 2018-02-21 01:31 PST by Xabier Rodríguez Calvar
Modified: 2018-02-21 05:26 PST (History)
4 users (show)

See Also:

Patch (4.79 KB, patch)
2018-02-21 03:17 PST, Philippe Normand
calvaris: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xabier Rodríguez Calvar 2018-02-21 01:31:25 PST
If you check https://bugzilla.gnome.org/show_bug.cgi?id=743062 you'll see like after 1.13.1, references are sinked and the GstGLDisplay object are really [transfer full] (before the docs say they were but they were [transfer floating]). We need to address this in runtime or we can crash or leak depending on the version.
Comment 1 Philippe Normand 2018-02-21 03:17:18 PST
Created attachment 334358 [details]
Comment 2 Philippe Normand 2018-02-21 05:25:52 PST
Committed r228869: <https://trac.webkit.org/changeset/228869>
Comment 3 Radar WebKit Bug Importer 2018-02-21 05:26:29 PST