RESOLVED INVALID 182968
[GStreamer] Create a Wayland GL display instead of EGL 
https://bugs.webkit.org/show_bug.cgi?id=182968
Summary [GStreamer] Create a Wayland GL display instead of EGL
Philippe Normand
Reported 2018-02-20 06:17:22 PST
This looks like an old copy/paste error.
Attachments
Patch (3.16 KB, patch)
2018-02-20 06:20 PST, Philippe Normand 		calvaris: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2018-02-20 06:20:21 PST
Created attachment 334264 [details] Patch
Xabier Rodríguez Calvar
Comment 2 2018-02-21 00:44:52 PST
Comment on attachment 334264 [details] Patch Wait, I think we have a leak here. All these gst_gl_display_*_new_with_egl_display are [transfer full] and we are not adopting them.
Xabier Rodríguez Calvar
Comment 3 2018-02-21 01:27:41 PST
Comment on attachment 334264 [details] Patch Before the patch landed on https://bugzilla.gnome.org/show_bug.cgi?id=743062 these references were still floating, thus we can't adopt or we would get crashes in debug mode. After that patch, we need to adopt or we would be leaking. I think we can land as it is but we need a new bug to fix this.
Philippe Normand
Comment 4 2018-02-21 01:35:00 PST
Committed r228866: <https://trac.webkit.org/changeset/228866>
Radar WebKit Bug Importer
Comment 5 2018-02-21 01:35:24 PST
<rdar://problem/37738006>
Carlos Garcia Campos
Comment 6 2018-02-26 06:21:55 PST
This is wrong, the display we want to use for rendering is the EGL display created and initialized by the PlatformDisplay. This patch causes runtime errors like: 0:00:46.130136714 13362 0x5609ff9524a0 ERROR webkitmediaplayer MediaPlayerPrivateGStreamer.cpp:956:handleMessage: Error 3: Failed to create a OpenGL context: EGL_BAD_CONTEXT (url=webkit+https://video.twimg.com/ext_tw_video/968118107192602624/pu/vid/640x360/dFLZDeagge7DOJd6.mp4) And then the web process hangs.
Carlos Garcia Campos
Comment 7 2018-02-26 06:23:51 PST
Reopening, not rolling out yet, just in case you have a quick fix. Otherwise, please roll it out.
Philippe Normand
Comment 8 2018-02-26 06:35:13 PST
Rolled out in r229022
Note You need to log in before you can comment on or make changes to this bug.