Bug 182968 - [GStreamer] Create a Wayland GL display instead of EGL
Summary: [GStreamer] Create a Wayland GL display instead of EGL
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on: 185207
Blocks: 182996
  Show dependency tree / graph
 
Reported: 2018-02-20 06:17 PST by Philippe Normand
Modified: 2018-05-02 10:52 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.16 KB, patch)
2018-02-20 06:20 PST, Philippe Normand 		calvaris: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2018-02-20 06:17:22 PST 
This looks like an old copy/paste error.
Comment 1 Philippe Normand 2018-02-20 06:20:21 PST 
Created attachment 334264 [details]
Patch
Comment 2 Xabier Rodríguez Calvar 2018-02-21 00:44:52 PST 
Comment on attachment 334264 [details]
Patch

Wait, I think we have a leak here. All these gst_gl_display_*_new_with_egl_display are [transfer full] and we are not adopting them.
Comment 3 Xabier Rodríguez Calvar 2018-02-21 01:27:41 PST 
Comment on attachment 334264 [details]
Patch

Before the patch landed on https://bugzilla.gnome.org/show_bug.cgi?id=743062 these references were still floating, thus we can't adopt or we would get crashes in debug mode. After that patch, we need to adopt or we would be leaking. I think we can land as it is but we need a new bug to fix this.
Comment 4 Philippe Normand 2018-02-21 01:35:00 PST 
Committed r228866: <https://trac.webkit.org/changeset/228866>
Comment 5 Radar WebKit Bug Importer 2018-02-21 01:35:24 PST 
<rdar://problem/37738006>
Comment 6 Carlos Garcia Campos 2018-02-26 06:21:55 PST 
This is wrong, the display we want to use for rendering is the EGL display created and initialized by the PlatformDisplay. This patch causes runtime errors like:

0:00:46.130136714 13362 0x5609ff9524a0 ERROR      webkitmediaplayer MediaPlayerPrivateGStreamer.cpp:956:handleMessage: Error 3: Failed to create a OpenGL context: EGL_BAD_CONTEXT (url=webkit+https://video.twimg.com/ext_tw_video/968118107192602624/pu/vid/640x360/dFLZDeagge7DOJd6.mp4)

And then the web process hangs.
Comment 7 Carlos Garcia Campos 2018-02-26 06:23:51 PST 
Reopening, not rolling out yet, just in case you have a quick fix. Otherwise, please roll it out.
Comment 8 Philippe Normand 2018-02-26 06:35:13 PST 
Rolled out in r229022