Bug 182900 - Remove UTF-32 BOM parsing code
Summary: Remove UTF-32 BOM parsing code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-16 19:26 PST by Daniel Bates
Modified: 2018-02-17 20:44 PST (History)
10 users (show)

See Also:

Attachments
Patch (7.33 KB, patch)
2018-02-16 19:31 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-sierra (2.37 MB, application/zip)
2018-02-16 20:31 PST, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews104 for mac-sierra-wk2 (2.57 MB, application/zip)
2018-02-16 20:45 PST, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews116 for mac-sierra (3.03 MB, application/zip)
2018-02-16 21:01 PST, EWS Watchlist 		no flags Details
Patch for landing (11.96 KB, patch)
2018-02-16 21:12 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2018-02-16 19:26:56 PST 
Support for UTF-32 encodings were removed in the patch for bug #179435. We should also remove code that made use of these encodings.
Comment 1 Daniel Bates 2018-02-16 19:27:29 PST 
<rdar://problem/37238717>
Comment 2 Daniel Bates 2018-02-16 19:31:56 PST 
Created attachment 334095 [details]
Patch
Comment 3 Alexey Proskuryakov 2018-02-16 20:20:35 PST 
Please update failing tests accordingly. Clearly, it’s not quite dead code.
Comment 4 EWS Watchlist 2018-02-16 20:31:19 PST 
Comment on attachment 334095 [details]
Patch

Attachment 334095 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6547182

New failing tests:
imported/w3c/web-platform-tests/encoding/utf-32.html
imported/w3c/web-platform-tests/encoding/unsupported-encodings.html
Comment 5 EWS Watchlist 2018-02-16 20:31:20 PST Comment hidden (obsolete)
Comment 6 EWS Watchlist 2018-02-16 20:45:55 PST Comment hidden (obsolete)
Comment 7 EWS Watchlist 2018-02-16 20:45:56 PST Comment hidden (obsolete)
Comment 8 EWS Watchlist 2018-02-16 21:01:48 PST Comment hidden (obsolete)
Comment 9 EWS Watchlist 2018-02-16 21:01:49 PST Comment hidden (obsolete)
Comment 10 Daniel Bates 2018-02-16 21:04:32 PST 
(In reply to Alexey Proskuryakov from comment #3)
> Please update failing tests accordingly. Clearly, it’s not quite dead code.

:)
Comment 11 Daniel Bates 2018-02-16 21:06:09 PST 
(In reply to Build Bot from comment #4)
> Comment on attachment 334095 [details]
> Patch
> 
> Attachment 334095 [details] did not pass mac-ews (mac):
> Output: http://webkit-queues.webkit.org/results/6547182
> 
> New failing tests:
> imported/w3c/web-platform-tests/encoding/utf-32.html
> imported/w3c/web-platform-tests/encoding/unsupported-encodings.html

Need to rebase these results. We now pass all subtests in these tests. Yay!
Comment 12 Daniel Bates 2018-02-16 21:12:57 PST 
Created attachment 334100 [details]
Patch for landing
Comment 13 WebKit Commit Bot 2018-02-16 21:50:04 PST 
Comment on attachment 334100 [details]
Patch for landing

Clearing flags on attachment: 334100

Committed r228594: <https://trac.webkit.org/changeset/228594>
Comment 14 WebKit Commit Bot 2018-02-16 21:50:05 PST 
All reviewed patches have been landed.  Closing bug.
Comment 15 Darin Adler 2018-02-17 14:37:27 PST 
Support for UTF-32 BOM is not "dead code" so the bug name here was a bit misleading. Change was what we want, though.
Comment 16 Daniel Bates 2018-02-17 20:44:12 PST 
(In reply to Darin Adler from comment #15)
> Support for UTF-32 BOM is not "dead code" so the bug name here was a bit
> misleading. Change was what we want, though.

You're right! Updated Bugzilla bug title and fixed up ChangeLog in <https://trac.webkit.org/changeset/228601>