Bug 179435 – Remove support for UTF-32 variant text encodings

• Status: RESOLVED
• Resolution: FIXED
• Component: Text

[Maciej Stachowiak]

Remove support for UTF-32 variant text encodings. There's no obvious reason we would need it, and having the support when other browsers don't is a security risk.

[Maciej Stachowiak]

Created attachment 326730 [details]
Patch

[Build Bot]

Comment on attachment 326730 [details]
Patch

Attachment 326730 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/5205088

New failing tests:
http/tests/misc/submit-get-in-utf32le.html
http/tests/misc/url-in-utf32le.html
http/tests/misc/submit-post-in-utf32be.html
http/tests/misc/submit-post-in-utf32le.html
http/tests/misc/submit-get-in-utf32be.html
http/tests/misc/url-in-utf32be.html

[Build Bot]

Created attachment 326731 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 326730 [details]
Patch

Attachment 326730 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5205103

New failing tests:
http/tests/misc/submit-get-in-utf32le.html
http/tests/misc/url-in-utf32le.html
http/tests/misc/submit-post-in-utf32be.html
http/tests/misc/submit-post-in-utf32le.html
http/tests/misc/submit-get-in-utf32be.html
http/tests/misc/url-in-utf32be.html

[Build Bot]

Created attachment 326732 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 326730 [details]
Patch

Attachment 326730 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/5205101

New failing tests:
http/tests/misc/submit-get-in-utf32le.html
http/tests/misc/url-in-utf32le.html
http/tests/misc/submit-post-in-utf32be.html
http/tests/misc/submit-post-in-utf32le.html
http/tests/misc/submit-get-in-utf32be.html
http/tests/misc/url-in-utf32be.html

[Build Bot]

Created attachment 326735 [details]
Archive of layout-test-results from ews114 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 326730 [details]
Patch

Attachment 326730 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/5205124

New failing tests:
http/tests/misc/submit-get-in-utf32le.html
http/tests/misc/url-in-utf32le.html
http/tests/misc/submit-post-in-utf32be.html
http/tests/misc/submit-post-in-utf32le.html
http/tests/misc/submit-get-in-utf32be.html
http/tests/misc/url-in-utf32be.html

[Build Bot]

Created attachment 326736 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[Maciej Stachowiak]

Looks like I need to remove or update a few more tests.

[Maciej Stachowiak]

Created attachment 326743 [details]
Patch

[Darin Adler]

Comment on attachment 326743 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326743&action=review

> LayoutTests/fast/encoding/legacy-utf-32-aliases.html:9
> +description("This test verifies that certain aliases for UTF-32 not supported.");

Noticed the word "are" is missing in this description.

[Maciej Stachowiak]

Created attachment 326746 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 326746 [details]
Patch for landing

Clearing flags on attachment: 326746

Committed r224747: <https://trac.webkit.org/changeset/224747>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35562305>

[Daniel Bates]

(In reply to WebKit Commit Bot from comment #14)
> Comment on attachment 326746 [details]
> Patch for landing
> 
> Clearing flags on attachment: 326746
> 
> Committed r224747: <https://trac.webkit.org/changeset/224747>

This change removed UTF-32{BE, LE} from the codec registry. We should also remove the UTF-32 BOM parsing code as well as the TextEncoding objects for these encodings. See bug #182900.