RESOLVED FIXED 182645
[CMake] Make PAL headers copies 
https://bugs.webkit.org/show_bug.cgi?id=182645
Summary [CMake] Make PAL headers copies
Don Olmstead
Reported 2018-02-09 11:40:31 PST
PAL headers should be copies.
Attachments
Patch (10.85 KB, patch)
2018-02-09 11:54 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (10.85 KB, patch)
2018-02-09 11:58 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (11.28 KB, patch)
2018-02-09 12:11 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (11.29 KB, patch)
2018-02-09 12:34 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (11.25 KB, patch)
2018-02-09 12:36 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (11.25 KB, patch)
2018-02-09 12:45 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2018-02-09 11:54:53 PST
Created attachment 333506 [details] Patch
Don Olmstead
Comment 2 2018-02-09 11:58:52 PST
Created attachment 333507 [details] Patch
Don Olmstead
Comment 3 2018-02-09 12:11:31 PST
Created attachment 333509 [details] Patch
EWS Watchlist
Comment 4 2018-02-09 12:12:48 PST
Attachment 333509 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/PlatformMac.cmake:83: There should be exactly one empty line instead of 0 between "spi/mac/TUCallSPI.h" and "spi/win/CoreTextSPIWin.h". [list/emptyline] [5] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Don Olmstead
Comment 5 2018-02-09 12:34:51 PST
Created attachment 333510 [details] Patch
Don Olmstead
Comment 6 2018-02-09 12:36:23 PST
Created attachment 333511 [details] Patch
Don Olmstead
Comment 7 2018-02-09 12:45:24 PST
Created attachment 333512 [details] Patch
WebKit Commit Bot
Comment 8 2018-02-09 16:51:16 PST
Comment on attachment 333512 [details] Patch Clearing flags on attachment: 333512 Committed r228347: <https://trac.webkit.org/changeset/228347>
WebKit Commit Bot
Comment 9 2018-02-09 16:51:18 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2018-02-09 16:52:25 PST
<rdar://problem/37410560>
Note You need to log in before you can comment on or make changes to this bug.