Bug 180064 - [Meta][CMake] Forwarding headers should be copies
Summary: [Meta][CMake] Forwarding headers should be copies
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 180063 182274 182303 182347 182512 182645
Blocks: 196704
  Show dependency tree / graph
 
Reported: 2017-11-27 20:21 PST by Don Olmstead
Modified: 2019-04-10 21:23 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2017-11-27 20:21:12 PST 
Meta bug for tracking copying forwarding headers within CMake to align with Apple ports.
Comment 1 Konstantin Tokarev 2017-11-28 01:44:22 PST 
No they should not
Comment 2 Csaba Osztrogonác 2018-01-30 14:18:10 PST 
(In reply to Konstantin Tokarev from comment #1)
> No they should not

I agree, we shouldn't do terrible hacks just because Apple Windows port does.
Comment 3 Don Olmstead 2018-01-30 14:21:57 PST 
(In reply to Csaba Osztrogonác from comment #2)
> (In reply to Konstantin Tokarev from comment #1)
> > No they should not
> 
> I agree, we shouldn't do terrible hacks just because Apple Windows port does.

We already litigated this in https://bugs.webkit.org/show_bug.cgi?id=180063 with mcatanzaro agreeing to the direction on the GTK/WPE side. A patch that copies JavaScriptCore headers is going through the bots now.