Bug 182542 – Serialize font-variation-settings with double-quotes per spec

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Chris Nardi]

Serialize font-variation-settings with double-quotes per spec

[Chris Nardi]

Created attachment 333190 [details]
Patch

[EWS Watchlist]

Attachment 333190 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:14:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Nardi]

Created attachment 333191 [details]
Update test

[Chris Nardi]

mmaxfield@, could you review?

[Myles C. Maxfield]

IIRC there was a previously contributed patch to change them to single quotes. We should talk with the person who wrote that patch to figure out the correct syntax.

[Chris Nardi]

(In reply to Myles C. Maxfield from comment #5)
> IIRC there was a previously contributed patch to change them to single
> quotes. We should talk with the person who wrote that patch to figure out
> the correct syntax.

Perhaps you were thinking of bug 182201 where I changed to double quotes for font-feature-settings? (Yes, this could've been one patch, but I found this bug after the last patch landed.)

Per https://drafts.csswg.org/cssom/#serialize-a-string, double quotes is correct, and I changed this behavior in Chrome a few months ago (I assume this is what Firefox does as well but their implementation of font-variation-settings is behind a flag).

[Chris Nardi]

(In reply to Chris Nardi from comment #6)
> Per https://drafts.csswg.org/cssom/#serialize-a-string, double quotes is
> correct, and I changed this behavior in Chrome a few months ago (I assume
> this is what Firefox does as well but their implementation of
> font-variation-settings is behind a flag).

Yep, Firefox does use double quotes per the spec.

[WebKit Commit Bot]

Comment on attachment 333191 [details]
Update test

Clearing flags on attachment: 333191

Committed r231165: <https://trac.webkit.org/changeset/231165>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/39845194>