Bug 182201 - Use double-quotes when serializing font-feature-settings
Summary: Use double-quotes when serializing font-feature-settings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-26 17:33 PST by Chris Nardi
Modified: 2018-04-25 09:39 PDT (History)
4 users (show)

See Also:


Attachments
Patch (9.39 KB, patch)
2018-01-26 17:36 PST, Chris Nardi
no flags Details | Formatted Diff | Diff
Update fast/text/font-face-javascript.html (13.73 KB, patch)
2018-01-26 18:09 PST, Chris Nardi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Nardi 2018-01-26 17:33:03 PST
Use double-quotes when serializing font-feature-settings
Comment 1 Chris Nardi 2018-01-26 17:36:55 PST
Created attachment 332441 [details]
Patch
Comment 2 Chris Nardi 2018-01-26 18:09:28 PST
Created attachment 332446 [details]
Update fast/text/font-face-javascript.html
Comment 3 Myles C. Maxfield 2018-01-30 15:43:52 PST
Comment on attachment 332446 [details]
Update fast/text/font-face-javascript.html

View in context: https://bugs.webkit.org/attachment.cgi?id=332446&action=review

> LayoutTests/ChangeLog:6
> +        Update tests with double-quotes instead of single-quotes.

Why?
Comment 4 Myles C. Maxfield 2018-01-30 15:44:25 PST
(In reply to Myles C. Maxfield from comment #3)
> Comment on attachment 332446 [details]
> Update fast/text/font-face-javascript.html
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=332446&action=review
> 
> > LayoutTests/ChangeLog:6
> > +        Update tests with double-quotes instead of single-quotes.
> 
> Why?

Oh, never mind, you explain it below.
Comment 5 WebKit Commit Bot 2018-01-30 16:08:49 PST
Comment on attachment 332446 [details]
Update fast/text/font-face-javascript.html

Clearing flags on attachment: 332446

Committed r227862: <https://trac.webkit.org/changeset/227862>
Comment 6 WebKit Commit Bot 2018-01-30 16:08:50 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-01-30 16:11:46 PST
<rdar://problem/37047234>
Comment 8 Simon Fraser (smfr) 2018-01-30 16:15:34 PST
Comment on attachment 332446 [details]
Update fast/text/font-face-javascript.html

View in context: https://bugs.webkit.org/attachment.cgi?id=332446&action=review

> Source/WebCore/ChangeLog:10
> +        Reviewed by NOBODY (OOPS!).

This should go above the description, after the bug number.