Bug 182403 – Configure serviceWorkerRegistrationDirectory on the web site data store and move it to a Caches subfolder as a default

• Status: RESOLVED
• Resolution: FIXED
• Component: Service Workers

[youenn fablet]

Configure serviceWorkerRegistrationDirectory on the web site data store and move it to a Caches subfolder as a default

[youenn fablet]

<rdar://problem/36673358>

[youenn fablet]

Created attachment 332902 [details]
Patch

[youenn fablet]

Created attachment 332929 [details]
Patch

[Chris Dumez]

It'd be good if Alex or Brady took a look at this one.

[WebKit Commit Bot]

Comment on attachment 332929 [details]
Patch

Clearing flags on attachment: 332929

Committed r228019: <https://trac.webkit.org/changeset/228019>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[youenn fablet]

Reopening to attach new patch.

[youenn fablet]

Created attachment 333014 [details]
Follow-up fix

[WebKit Commit Bot]

Comment on attachment 333014 [details]
Follow-up fix

Clearing flags on attachment: 333014

Committed r228033: <https://trac.webkit.org/changeset/228033>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Chris Dumez]

After this change, it seems all WebKitTestRunner instances share the same registration database direction, thus introducing flakiness :/

[Chris Dumez]

Comment on attachment 332929 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332929&action=review

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:111
> +    void setServiceWorkerRegistrationDirectory(String&& directory) { m_resolvedConfiguration.serviceWorkerRegistrationDirectory = WTFMove(directory); }

WebsiteDataStore::resolveDirectoriesIfNecessary() overrides the path you set here in the resolvedConfiguration with the default path that is in the configuration :/

[youenn fablet]

(In reply to Chris Dumez from comment #12)
> Comment on attachment 332929 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=332929&action=review
> 
> > Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:111
> > +    void setServiceWorkerRegistrationDirectory(String&& directory) { m_resolvedConfiguration.serviceWorkerRegistrationDirectory = WTFMove(directory); }
> 
> WebsiteDataStore::resolveDirectoriesIfNecessary() overrides the path you set
> here in the resolvedConfiguration with the default path that is in the
> configuration :/

Filed https://bugs.webkit.org/show_bug.cgi?id=182514