Bug 182101 - [WebVR] Make WebVR available by default for developer builds
Summary: [WebVR] Make WebVR available by default for developer builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-25 07:35 PST by Sergio Villar Senin
Modified: 2018-01-26 00:55 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.02 KB, patch)
2018-01-25 07:36 PST, Sergio Villar Senin 		mcatanzaro: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2018-01-25 07:35:31 PST 
[WebVR] Make WebVR available by default for developer builds
Comment 1 Sergio Villar Senin 2018-01-25 07:36:27 PST 
Created attachment 332264 [details]
Patch
Comment 2 Michael Catanzaro 2018-01-25 10:31:42 PST 
Comment on attachment 332264 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332264&action=review

> Source/WebKit/Shared/WebPreferences.yaml:1196
> +  condition: PLATFORM(GTK) || PLATFORM(WPE)

Note the condition line is only there to keep it from showing up in the Safari Tech Preview experimental features list. I assume someone from Apple would want to approve that.)
Comment 3 Sergio Villar Senin 2018-01-26 00:48:23 PST 
As mentioned by Alex in bug 182047 Apple is not even interested in enabling it in developer builds for the moment, so we're safe.
Comment 4 Sergio Villar Senin 2018-01-26 00:54:34 PST 
Committed r227669: <https://trac.webkit.org/changeset/227669>
Comment 5 Radar WebKit Bug Importer 2018-01-26 00:55:26 PST 
<rdar://problem/36901968>