Bug 182047 - [Mac][WebVR] Add the build machinery for in-tree OpenVR
Summary: [Mac][WebVR] Add the build machinery for in-tree OpenVR
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 177298
  Show dependency tree / graph
 
Reported: 2018-01-24 07:27 PST by Sergio Villar Senin
Modified: 2020-07-05 23:49 PDT (History)
6 users (show)

See Also:

Attachments
WIP (4.97 KB, patch)
2018-01-24 07:29 PST, Sergio Villar Senin 		no flags Details | Formatted Diff | Diff
WIP (37.60 KB, patch)
2018-01-24 07:32 PST, Sergio Villar Senin 		no flags Details | Formatted Diff | Diff
WIP (34.59 KB, patch)
2018-10-01 02:45 PDT, Frédéric Wang (:fredw) 		no flags Details | Formatted Diff | Diff
WIP (38.71 KB, patch)
2018-10-01 11:16 PDT, Frédéric Wang (:fredw) 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2018-01-24 07:27:00 PST 
OpenVR was added to the tree in bug 177298. I tried to add the required information to get it building in MacOS but I was totally unable to do it without also affecting iOS. I'd need a Mac build system expert here.

I'm attaching what I've done so far just int case it could be used.
Comment 1 Sergio Villar Senin 2018-01-24 07:29:57 PST 
Created attachment 332161 [details]
WIP
Comment 2 Sergio Villar Senin 2018-01-24 07:32:08 PST 
Created attachment 332162 [details]
WIP
Comment 3 Alex Christensen 2018-01-25 10:46:36 PST 
FYI, you can add most of the build system, but we probably won't want to build it by default with make or build-webkit until we decide to enable the feature.
Comment 4 Sergio Villar Senin 2018-01-26 00:47:08 PST 
(In reply to Alex Christensen from comment #3)
> FYI, you can add most of the build system, but we probably won't want to
> build it by default with make or build-webkit until we decide to enable the
> feature.

I'm fine with that. I just don't know how to do all that (and also disable it for iOS) on Xcode. That's why I'd be more than happy to see some other taking this over for me.
Comment 5 Frédéric Wang (:fredw) 2018-10-01 02:45:44 PDT 
Created attachment 351229 [details]
WIP

Just trying to rebase Sergio's patch...
Comment 6 Frédéric Wang (:fredw) 2018-10-01 11:16:27 PDT 
Created attachment 351277 [details]
WIP

This adds more headers to XCode. Then compilation fails because of a warning ( https://github.com/ValveSoftware/openvr/pull/898 ) and link fails because of duplicated symbols (e.g. jsoncpp already exists in webrtc).
Comment 7 Sergio Villar Senin 2020-07-05 23:49:04 PDT 
OpenVR was removed from tree. Same happened with WebVR code. Closing now.