The following layout tests are flaky on macOS Debug media/W3C/audio/events/event_progress.html media/W3C/video/events/event_order_loadstart_progress.html Probable cause: This has been flaky for an extended period of time and the failures extend beyond the flakiness dashboard Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2FW3C%2Faudio%2Fevents%2Fevent_progress.html build: https://build.webkit.org/results/Apple%20High%20Sierra%20Debug%20WK2%20(Tests)/r227351%20(1725)/results.html https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20WK2%20(Tests)/builds/1725 diff: --- /Volumes/Data/slave/highsierra-debug-tests-wk2/build/layout-test-results/media/W3C/audio/events/event_progress-expected.txt +++ /Volumes/Data/slave/highsierra-debug-tests-wk2/build/layout-test-results/media/W3C/audio/events/event_progress-actual.txt @@ -6,6 +6,9 @@ PASS true is true TEST COMPLETE +PASS true is true + +TEST COMPLETE spec reference It looks like the tests are intermittently duplicating the pass message.
Flakiness dashboard for media/W3C/video/events/event_order_loadstart_progress.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2FW3C%2Fvideo%2Fevents%2Fevent_order_loadstart_progress.html
Marked as flaky in https://trac.webkit.org/changeset/227454/webkit
<rdar://problem/51449034>
*** Bug 175678 has been marked as a duplicate of this bug. ***
*** Bug 177663 has been marked as a duplicate of this bug. ***
Created attachment 380689 [details] Patch
Created attachment 380697 [details] Patch
Comment on attachment 380697 [details] Patch Clearing flags on attachment: 380697 Committed r251009: <https://trac.webkit.org/changeset/251009>
All reviewed patches have been landed. Closing bug.
Comment on attachment 380697 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380697&action=review > LayoutTests/ChangeLog:16 > + * http/tests/resources/js-test-pre.js: > + (isSuccessfullyParsed): I don't see any changes to this file in this patch. > LayoutTests/ChangeLog:25 > + * platform/ios/TestExpectations: > + * platform/mac/TestExpectations: I related some more bugs about tests unmarked here. > LayoutTests/media/W3C/audio/events/event_order_loadstart_progress.html:20 > +var firstProgressEvent = true; I think that you can just use {once: true} here and elsewhere in this change. > LayoutTests/media/W3C/audio/events/event_order_loadstart_progress.html:22 > + if (!firstProgressEvent) return; WebKit coding style would be to have "return;" on its own line. But perhaps you are matching coding style of this test suite? I don't see existing examples in this diff.
Comment on attachment 380697 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380697&action=review >> LayoutTests/ChangeLog:16 >> + (isSuccessfullyParsed): > > I don't see any changes to this file in this patch. Ah, forgot to review the list of changes after revising the patch. >> LayoutTests/media/W3C/audio/events/event_order_loadstart_progress.html:20 >> +var firstProgressEvent = true; > > I think that you can just use {once: true} here and elsewhere in this change. Right! >> LayoutTests/media/W3C/audio/events/event_order_loadstart_progress.html:22 >> + if (!firstProgressEvent) return; > > WebKit coding style would be to have "return;" on its own line. But perhaps you are matching coding style of this test suite? I don't see existing examples in this diff. Right, it needs to be fixed. If we use the "once" option on addEventListner, then this line needs to be removed.
Reopening to attach new patch.
Created attachment 380779 [details] Patch
Comment on attachment 380779 [details] Patch Clearing flags on attachment: 380779 Committed r251030: <https://trac.webkit.org/changeset/251030>
*** Bug 196637 has been marked as a duplicate of this bug. ***
*** Bug 184614 has been marked as a duplicate of this bug. ***