Bug 181863 - REGRESSION (r223149): Ref WebPageProxy objects before calling their functionality
Summary: REGRESSION (r223149): Ref WebPageProxy objects before calling their functiona...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
Keywords: InRadar, Regression
Depends on: 178102
  Show dependency treegraph
Reported: 2018-01-19 10:10 PST by Daniel Bates
Modified: 2018-01-19 11:02 PST (History)
4 users (show)

See Also:

Patch (3.08 KB, patch)
2018-01-19 10:20 PST, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2018-01-19 10:10:57 PST
Changeset <https://trac.webkit.org/changeset/223149/> (bug #178102) inadvertently changed the copying semantics in WebProcessProxy such that we no longer ref WebPageProxy objects before calling their functionality. In bug #181771 we fixed this inadvertent change made in WebProcessProxy::didClose(). There are more places that r223149 touched that we need to fix up. It is not safe to loop over WebPageProxy objects calling functionality that may call a delegate because the delegate can do anything including deallocating itself and other WebPageProxy objects.
Comment 1 Radar WebKit Bug Importer 2018-01-19 10:11:50 PST
Comment 2 Daniel Bates 2018-01-19 10:20:07 PST
Created attachment 331748 [details]
Comment 3 Chris Dumez 2018-01-19 10:21:10 PST
Comment on attachment 331748 [details]

Comment 4 Daniel Bates 2018-01-19 11:02:09 PST
Comment on attachment 331748 [details]

Clearing flags on attachment: 331748

Committed r227218: <https://trac.webkit.org/changeset/227218>
Comment 5 Daniel Bates 2018-01-19 11:02:10 PST
All reviewed patches have been landed.  Closing bug.