Bug 178102 - Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
Summary: Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/cop...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on: 181771
Blocks: 181863
  Show dependency tree / graph
 
Reported: 2017-10-09 17:09 PDT by Sam Weinig
Modified: 2018-01-19 10:11 PST (History)
5 users (show)

See Also:

Attachments
Patch (41.67 KB, patch)
2017-10-09 17:15 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (41.23 KB, patch)
2017-10-09 17:22 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (41.08 KB, patch)
2017-10-09 20:01 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (41.08 KB, patch)
2017-10-09 20:25 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (41.33 KB, patch)
2017-10-10 08:20 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2017-10-09 17:09:23 PDT 
Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
Comment 1 Sam Weinig 2017-10-09 17:15:24 PDT Comment hidden (obsolete)
Comment 2 Sam Weinig 2017-10-09 17:22:37 PDT Comment hidden (obsolete)
Comment 3 Sam Weinig 2017-10-09 20:01:57 PDT Comment hidden (obsolete)
Comment 4 Sam Weinig 2017-10-09 20:25:17 PDT Comment hidden (obsolete)
Comment 5 Sam Weinig 2017-10-10 08:20:34 PDT 
Created attachment 323309 [details]
Patch
Comment 6 WebKit Commit Bot 2017-10-10 15:13:11 PDT 
Comment on attachment 323309 [details]
Patch

Clearing flags on attachment: 323309

Committed r223149: <http://trac.webkit.org/changeset/223149>
Comment 7 WebKit Commit Bot 2017-10-10 15:13:12 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-10-10 15:14:01 PDT 
<rdar://problem/34920783>
Comment 9 Chris Dumez 2018-01-17 16:32:16 PST 
Comment on attachment 323309 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323309&action=review

> Source/WebKit/UIProcess/WebProcessProxy.cpp:625
> +    auto pages = copyToVector(m_pageMap.values());

This used to ref the pages and now it no longer does (rdar://problem/36566237).