RESOLVED FIXED 178102
Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values()) 
https://bugs.webkit.org/show_bug.cgi?id=178102
Summary Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/cop...
Sam Weinig
Reported 2017-10-09 17:09:23 PDT
Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
Attachments
Patch (41.67 KB, patch)
2017-10-09 17:15 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (41.23 KB, patch)
2017-10-09 17:22 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (41.08 KB, patch)
2017-10-09 20:01 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (41.08 KB, patch)
2017-10-09 20:25 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (41.33 KB, patch)
2017-10-10 08:20 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2017-10-09 17:15:24 PDT Comment hidden (obsolete)
Sam Weinig
Comment 2 2017-10-09 17:22:37 PDT Comment hidden (obsolete)
Sam Weinig
Comment 3 2017-10-09 20:01:57 PDT Comment hidden (obsolete)
Sam Weinig
Comment 4 2017-10-09 20:25:17 PDT Comment hidden (obsolete)
Sam Weinig
Comment 5 2017-10-10 08:20:34 PDT
Created attachment 323309 [details] Patch
WebKit Commit Bot
Comment 6 2017-10-10 15:13:11 PDT
Comment on attachment 323309 [details] Patch Clearing flags on attachment: 323309 Committed r223149: <http://trac.webkit.org/changeset/223149>
WebKit Commit Bot
Comment 7 2017-10-10 15:13:12 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2017-10-10 15:14:01 PDT
<rdar://problem/34920783>
Chris Dumez
Comment 9 2018-01-17 16:32:16 PST
Comment on attachment 323309 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323309&action=review > Source/WebKit/UIProcess/WebProcessProxy.cpp:625 > + auto pages = copyToVector(m_pageMap.values()); This used to ref the pages and now it no longer does (rdar://problem/36566237).
Note You need to log in before you can comment on or make changes to this bug.