Bug 181608 - Logged JSON should escape "'s and \'s in strings.
Summary: Logged JSON should escape "'s and \'s in strings.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-12 12:07 PST by Keith Rollin
Modified: 2018-01-12 13:40 PST (History)
7 users (show)

See Also:

Attachments
Patch (6.34 KB, patch)
2018-01-12 12:23 PST, Keith Rollin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2018-01-12 12:07:14 PST 
The logging in bug 181556 and bug 180883 should properly escape strings printed as part of JSON-formatted output.
Comment 1 Keith Rollin 2018-01-12 12:23:34 PST 
Created attachment 331225 [details]
Patch
Comment 2 EWS Watchlist 2018-01-12 12:26:22 PST 
Attachment 331225 [details] did not pass style-queue:


ERROR: Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:748:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:749:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:750:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:767:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:768:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:769:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:770:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:776:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:777:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/loader/ResourceLoadObserver.cpp:316:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/loader/ResourceLoadObserver.cpp:317:  Missing space before {  [whitespace/braces] [5]
Total errors found: 11 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Brent Fulgham 2018-01-12 12:43:37 PST 
Comment on attachment 331225 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2018-01-12 13:39:05 PST 
Comment on attachment 331225 [details]
Patch

Clearing flags on attachment: 331225

Committed r226913: <https://trac.webkit.org/changeset/226913>
Comment 5 WebKit Commit Bot 2018-01-12 13:39:06 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-01-12 13:40:34 PST 
<rdar://problem/36481015>