Bug 181556 – Add optional logging of ITP-related user interaction information

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Keith Rollin]

In order to support the tracking of the efficacy of Intelligent Tracking Protection, add some logging indicating when the user interacts with a page in a way that affects cookie partitioning. This logging is off by default, and is enabled with `defaults write -g WebKitLogCookieInformation -bool true`.

[Keith Rollin]

Created attachment 331109 [details]
Patch

[EWS Watchlist]

Attachment 331109 [details] did not pass style-queue:


ERROR: Source/WebCore/loader/ResourceLoadObserver.cpp:309:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/loader/ResourceLoadObserver.cpp:310:  Missing space before {  [whitespace/braces] [5]
Total errors found: 2 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brent Fulgham]

Comment on attachment 331109 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331109&action=review

> Source/WebCore/loader/ResourceLoadObserver.cpp:305
> +        auto counter = ++m_loggingCounter;

I think this is guaranteed to always happen on the Main Thread, so m_loggingCounter might not need to be <atomic>. But this only happens in instrumented builds, so it's not worth worrying about.

[Brent Fulgham]

So r=me.

[Chris Dumez]

Comment on attachment 331109 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331109&action=review

>> Source/WebCore/loader/ResourceLoadObserver.cpp:305
>> +        auto counter = ++m_loggingCounter;
> 
> I think this is guaranteed to always happen on the Main Thread, so m_loggingCounter might not need to be <atomic>. But this only happens in instrumented builds, so it's not worth worrying about.

Yes, always called from the same thread, otherwise the call to m_notificationTimer.stop(); above would be very unsafe. Please drop the atomic.

[Keith Rollin]

Created attachment 331138 [details]
Patch

[EWS Watchlist]

Attachment 331138 [details] did not pass style-queue:


ERROR: Source/WebCore/loader/ResourceLoadObserver.cpp:309:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/loader/ResourceLoadObserver.cpp:310:  Missing space before {  [whitespace/braces] [5]
Total errors found: 2 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 331138 [details]
Patch

Clearing flags on attachment: 331138

Committed r226835: <https://trac.webkit.org/changeset/226835>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/36455886>