Bug 181201 - [Attachment Support] Add plumbing for starting a drag with promised blob data
Summary: [Attachment Support] Add plumbing for starting a drag with promised blob data
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on: 181189 181190
Blocks: 181199 181294
  Show dependency tree / graph
 
Reported: 2017-12-31 19:19 PST by Wenson Hsieh
Modified: 2018-01-05 11:09 PST (History)
8 users (show)

See Also:

Attachments
Won't apply (see dependencies) (28.09 KB, patch)
2017-12-31 22:55 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
v2 (still blocked on dependencies) (44.69 KB, patch)
2018-01-01 17:27 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
v3 (rebased and modified) (40.36 KB, patch)
2018-01-02 23:50 PST, Wenson Hsieh 		thorton: review+
Details | Formatted Diff | Diff
Patch for landing (40.28 KB, patch)
2018-01-03 20:10 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2017-12-31 19:19:53 PST 
Work towards dragging attachments as files on macOS and iOS.
Comment 1 Wenson Hsieh 2017-12-31 22:55:59 PST 
Created attachment 330281 [details]
Won't apply (see dependencies)
Comment 2 Wenson Hsieh 2018-01-01 17:27:11 PST 
Created attachment 330302 [details]
v2 (still blocked on dependencies)
Comment 3 Wenson Hsieh 2018-01-02 23:50:51 PST 
Created attachment 330368 [details]
v3 (rebased and modified)
Comment 4 Tim Horton 2018-01-03 15:04:20 PST 
Comment on attachment 330368 [details]
v3 (rebased and modified)

View in context: https://bugs.webkit.org/attachment.cgi?id=330368&action=review

> Source/WebCore/page/DragClient.h:40
> +struct PromisedBlobData;

Don’t need this anymore (in many places)

> Source/WebKit/Scripts/webkit/messages.py:377
> +        'WebCore::PromisedBlobInfo': ['<WebCore/PromisedBlobInfo.h>'],

Again, shouldn’t be needed.
Comment 5 Wenson Hsieh 2018-01-03 20:10:18 PST 
Created attachment 330436 [details]
Patch for landing
Comment 6 Wenson Hsieh 2018-01-03 20:10:27 PST 
Comment on attachment 330368 [details]
v3 (rebased and modified)

View in context: https://bugs.webkit.org/attachment.cgi?id=330368&action=review

>> Source/WebCore/page/DragClient.h:40
>> +struct PromisedBlobData;
> 
> Don’t need this anymore (in many places)

Removed!

>> Source/WebKit/Scripts/webkit/messages.py:377
>> +        'WebCore::PromisedBlobInfo': ['<WebCore/PromisedBlobInfo.h>'],
> 
> Again, shouldn’t be needed.

Good catch — removed.
Comment 7 Wenson Hsieh 2018-01-03 21:51:39 PST 
Comment on attachment 330436 [details]
Patch for landing

commit-queue is unresponsive again, but EWS is all green. I'm going to just land this.
Comment 8 Wenson Hsieh 2018-01-03 21:58:36 PST 
Committed r226393: <https://trac.webkit.org/changeset/226393>.
Comment 9 Lucas Forschler 2018-01-04 05:31:42 PST 
Did you notify anyone that commit queue was unresponsive?
Comment 10 Wenson Hsieh 2018-01-04 07:43:20 PST 
(In reply to Lucas Forschler from comment #9)
> Did you notify anyone that commit queue was unresponsive?

No. Would you recommend that I notify you, Alexey, Dean Johnson, Aakash, or perhaps someone else?
Comment 11 Lucas Forschler 2018-01-04 12:52:54 PST 
Any of those would work, or a bugzilla bug assigned to one of us would be even better. Thanks!
Comment 12 Radar WebKit Bug Importer 2018-01-04 12:58:16 PST 
<rdar://problem/36303724>
Comment 13 Aakash Jain 2018-01-05 11:09:58 PST 
(In reply to Lucas Forschler from comment #11)
> Any of those would work, or a bugzilla bug assigned to one of us would be even better. Thanks!
Tracked in https://bugs.webkit.org/show_bug.cgi?id=181332