Bug 181189 - [Attachment Support] Introduce data structures and IPC support for writing promised blobs
Summary: [Attachment Support] Introduce data structures and IPC support for writing pr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks: 181190 181201
  Show dependency tree / graph
 
Reported: 2017-12-29 15:02 PST by Wenson Hsieh
Modified: 2018-01-02 19:44 PST (History)
7 users (show)

See Also:

Attachments
Patch (12.49 KB, patch)
2017-12-29 15:15 PST, Wenson Hsieh 		thorton: review+
Details | Formatted Diff | Diff
Patch for landing (12.39 KB, patch)
2018-01-02 17:33 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2017-12-29 15:02:23 PST 
Work towards async drag and drop support for blobs on iOS/macOS.
Comment 1 Wenson Hsieh 2017-12-29 15:15:06 PST 
Created attachment 330260 [details]
Patch
Comment 2 Tim Horton 2018-01-02 17:02:56 PST 
Comment on attachment 330260 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330260&action=review

> Source/WebKit/Shared/WebCoreArgumentCoders.h:701
> +template<> struct ArgumentCoder<WebCore::PromisedBlobData> {

I /think/ we're not supposed to add things to these files anymore, but stick them with the type instead? With the magical new WebCore coders? I'm not sure. Alex would know.
Comment 3 Wenson Hsieh 2018-01-02 17:10:59 PST 
(In reply to Tim Horton from comment #2)
> Comment on attachment 330260 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=330260&action=review
> 
> > Source/WebKit/Shared/WebCoreArgumentCoders.h:701
> > +template<> struct ArgumentCoder<WebCore::PromisedBlobData> {
> 
> I /think/ we're not supposed to add things to these files anymore, but stick
> them with the type instead? With the magical new WebCore coders? I'm not
> sure. Alex would know.

I see. I put this here (instead of defining WebCore coder methods) because this needs to ship a SharedBuffer over to the UI process, which (AFAIK) uses some WebKit machinery, like SharedMemory. Should that be brought into in WebCore instead? Or would this have to call into the client to know how to encode a SharedBuffer?
Comment 4 Tim Horton 2018-01-02 17:16:39 PST 
Ah! You had a good reason, ignore me!
Comment 5 Tim Horton 2018-01-02 17:20:53 PST 
Comment on attachment 330260 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330260&action=review

> Source/WebCore/platform/PromisedBlobInfo.h:45
> +    String filepath;

filepath seems weirdly capitalized? filePath? path?
Comment 6 Wenson Hsieh 2018-01-02 17:22:20 PST 
(In reply to Tim Horton from comment #5)
> Comment on attachment 330260 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=330260&action=review
> 
> > Source/WebCore/platform/PromisedBlobInfo.h:45
> > +    String filepath;
> 
> filepath seems weirdly capitalized? filePath? path?

Oh, right — this should be filePath. Fixed!
Comment 7 Wenson Hsieh 2018-01-02 17:33:32 PST 
Created attachment 330359 [details]
Patch for landing
Comment 8 Wenson Hsieh 2018-01-02 18:55:30 PST 
(In reply to Wenson Hsieh from comment #7)
> Created attachment 330359 [details]
> Patch for landing

Looks like commit-queue is unresponsive…

Committed r226348: <https://trac.webkit.org/changeset/226348>.
Comment 9 Radar WebKit Bug Importer 2018-01-02 19:07:42 PST 
<rdar://problem/36268535>
Comment 10 Yusuke Suzuki 2018-01-02 19:44:06 PST 
Committed r226350: <https://trac.webkit.org/changeset/226350>