Bug 181189 – [Attachment Support] Introduce data structures and IPC support for writing promised blobs

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Wenson Hsieh]

Work towards async drag and drop support for blobs on iOS/macOS.

[Wenson Hsieh]

Created attachment 330260 [details]
Patch

[Tim Horton]

Comment on attachment 330260 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330260&action=review

> Source/WebKit/Shared/WebCoreArgumentCoders.h:701
> +template<> struct ArgumentCoder<WebCore::PromisedBlobData> {

I /think/ we're not supposed to add things to these files anymore, but stick them with the type instead? With the magical new WebCore coders? I'm not sure. Alex would know.

[Wenson Hsieh]

(In reply to Tim Horton from comment #2)
> Comment on attachment 330260 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=330260&action=review
> 
> > Source/WebKit/Shared/WebCoreArgumentCoders.h:701
> > +template<> struct ArgumentCoder<WebCore::PromisedBlobData> {
> 
> I /think/ we're not supposed to add things to these files anymore, but stick
> them with the type instead? With the magical new WebCore coders? I'm not
> sure. Alex would know.

I see. I put this here (instead of defining WebCore coder methods) because this needs to ship a SharedBuffer over to the UI process, which (AFAIK) uses some WebKit machinery, like SharedMemory. Should that be brought into in WebCore instead? Or would this have to call into the client to know how to encode a SharedBuffer?

[Tim Horton]

Ah! You had a good reason, ignore me!

[Tim Horton]

Comment on attachment 330260 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330260&action=review

> Source/WebCore/platform/PromisedBlobInfo.h:45
> +    String filepath;

filepath seems weirdly capitalized? filePath? path?

[Wenson Hsieh]

(In reply to Tim Horton from comment #5)
> Comment on attachment 330260 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=330260&action=review
> 
> > Source/WebCore/platform/PromisedBlobInfo.h:45
> > +    String filepath;
> 
> filepath seems weirdly capitalized? filePath? path?

Oh, right — this should be filePath. Fixed!

[Wenson Hsieh]

Created attachment 330359 [details]
Patch for landing

[Wenson Hsieh]

(In reply to Wenson Hsieh from comment #7)
> Created attachment 330359 [details]
> Patch for landing

Looks like commit-queue is unresponsive…

Committed r226348: <https://trac.webkit.org/changeset/226348>.

[Radar WebKit Bug Importer]

<rdar://problem/36268535>

[Yusuke Suzuki]

Committed r226350: <https://trac.webkit.org/changeset/226350>