Bug 181178 - Allow passing MessagePorts across processes (e.g. ServiceWorkers)
Summary: Allow passing MessagePorts across processes (e.g. ServiceWorkers)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
: 178940 (view as bug list)
Depends on: 181172 181205 181454 181910
Blocks:
  Show dependency treegraph
 
Reported: 2017-12-27 22:14 PST by Brady Eidson
Modified: 2018-01-31 15:00 PST (History)
10 users (show)

See Also:


Attachments
Super preliminary work (88.17 KB, patch)
2018-01-08 19:20 PST, Brady Eidson
no flags Details | Formatted Diff | Diff
Still early, now without unrelated cruft (88.17 KB, patch)
2018-01-08 19:21 PST, Brady Eidson
no flags Details | Formatted Diff | Diff
Still early, now without unrelated cruft (87.80 KB, patch)
2018-01-08 19:22 PST, Brady Eidson
no flags Details | Formatted Diff | Diff
Still early - Should apply? (87.80 KB, patch)
2018-01-09 09:19 PST, Brady Eidson
no flags Details | Formatted Diff | Diff
Fixed release build (87.83 KB, patch)
2018-01-09 11:08 PST, Brady Eidson
no flags Details | Formatted Diff | Diff
Patch (44.98 KB, patch)
2018-01-22 17:10 PST, Brady Eidson
no flags Details | Formatted Diff | Diff
Patch (46.70 KB, patch)
2018-01-22 18:32 PST, Brady Eidson
no flags Details | Formatted Diff | Diff
Patch (46.95 KB, patch)
2018-01-22 18:59 PST, Brady Eidson
no flags Details | Formatted Diff | Diff
Patch (47.25 KB, patch)
2018-01-22 19:43 PST, Brady Eidson
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (2.08 MB, application/zip)
2018-01-22 20:38 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.15 MB, application/zip)
2018-01-22 21:04 PST, EWS Watchlist
no flags Details
Patch (92.16 KB, patch)
2018-01-22 21:41 PST, Brady Eidson
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (2.82 MB, application/zip)
2018-01-22 22:52 PST, EWS Watchlist
no flags Details
Patch (92.15 KB, patch)
2018-01-22 23:13 PST, Brady Eidson
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.13 MB, application/zip)
2018-01-23 02:45 PST, EWS Watchlist
no flags Details
Patch (97.98 KB, patch)
2018-01-23 09:40 PST, Brady Eidson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2017-12-27 22:14:06 PST
Allow passing MessagePorts across processes (e.g. ServiceWorkers)
Comment 1 Brady Eidson 2018-01-08 19:20:05 PST
Created attachment 330780 [details]
Super preliminary work

Super preliminary while I continue flushing out the test landscape
Comment 2 Brady Eidson 2018-01-08 19:21:38 PST Comment hidden (obsolete)
Comment 3 Brady Eidson 2018-01-08 19:22:45 PST
Created attachment 330782 [details]
Still early, now without unrelated cruft
Comment 4 EWS Watchlist 2018-01-08 19:24:40 PST
Attachment 330782 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/UIMessageChannel.cpp:61:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 29 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Brady Eidson 2018-01-09 09:19:50 PST
Created attachment 330829 [details]
Still early - Should apply?
Comment 6 EWS Watchlist 2018-01-09 10:23:26 PST
Attachment 330829 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/UIMessageChannel.cpp:61:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 29 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Brady Eidson 2018-01-09 10:27:33 PST
(In reply to Build Bot from comment #6)
> Attachment 330829 [details] did not pass style-queue:
> 
> 
> ERROR: Source/WebKit/UIProcess/UIMessageChannel.cpp:61:  Code inside a
> namespace should not be indented.  [whitespace/indent] [4]
> Total errors found: 1 in 29 files
> 
> 
> If any of these errors are false positives, please file a bug against
> check-webkit-style.

It's definitely wrong.

Filed over here:
https://bugs.webkit.org/show_bug.cgi?id=181441
Comment 8 Brady Eidson 2018-01-09 11:08:24 PST
Created attachment 330836 [details]
Fixed release build
Comment 9 EWS Watchlist 2018-01-09 11:10:00 PST
Attachment 330836 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/UIMessageChannel.cpp:61:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 29 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 Brady Eidson 2018-01-22 17:10:35 PST
Created attachment 331984 [details]
Patch
Comment 11 Brady Eidson 2018-01-22 18:32:03 PST
Created attachment 331993 [details]
Patch
Comment 12 Brady Eidson 2018-01-22 18:36:04 PST
This is definitely going to change the results of some imported SW web platform tests and I haven't tested such locally. Code changes of patch still in a reviewable state. Probably.
Comment 13 Brady Eidson 2018-01-22 18:59:28 PST
Created attachment 331995 [details]
Patch
Comment 14 Brady Eidson 2018-01-22 19:43:30 PST
Created attachment 331996 [details]
Patch
Comment 15 Brady Eidson 2018-01-22 20:04:43 PST
*Lots* of test progressions in the w3c tests coming up.
Comment 16 Brady Eidson 2018-01-22 20:05:19 PST
(In reply to Brady Eidson from comment #15)
> *Lots* of test progressions in the w3c tests coming up.

(But maybe some regressions)
Comment 17 EWS Watchlist 2018-01-22 20:38:36 PST
Comment on attachment 331996 [details]
Patch

Attachment 331996 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/6177870

Number of test failures exceeded the failure limit.
Comment 18 EWS Watchlist 2018-01-22 20:38:38 PST
Created attachment 332002 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 19 EWS Watchlist 2018-01-22 21:04:38 PST
Comment on attachment 331996 [details]
Patch

Attachment 331996 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/6177905

Number of test failures exceeded the failure limit.
Comment 20 EWS Watchlist 2018-01-22 21:04:39 PST
Created attachment 332003 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6
Comment 21 Brady Eidson 2018-01-22 21:41:17 PST
Created attachment 332006 [details]
Patch
Comment 22 EWS Watchlist 2018-01-22 22:52:06 PST
Comment on attachment 332006 [details]
Patch

Attachment 332006 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/6178744

New failing tests:
fast/workers/worker-multi-port.html
fast/dom/Window/window-postmessage-args.html
fast/workers/worker-context-multi-port.html
fast/events/message-port-multi.html
Comment 23 EWS Watchlist 2018-01-22 22:52:08 PST
Created attachment 332008 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 24 Brady Eidson 2018-01-22 23:13:48 PST
Created attachment 332009 [details]
Patch
Comment 25 EWS Watchlist 2018-01-23 02:45:27 PST
Comment on attachment 332009 [details]
Patch

Attachment 332009 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/6180290

New failing tests:
imported/w3c/web-platform-tests/service-workers/service-worker/redirected-response.https.html
Comment 26 EWS Watchlist 2018-01-23 02:45:29 PST
Created attachment 332017 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6
Comment 27 Brady Eidson 2018-01-23 09:40:56 PST
Created attachment 332032 [details]
Patch
Comment 28 WebKit Commit Bot 2018-01-23 11:24:29 PST
Comment on attachment 332032 [details]
Patch

Clearing flags on attachment: 332032

Committed r227425: <https://trac.webkit.org/changeset/227425>
Comment 29 WebKit Commit Bot 2018-01-23 11:24:30 PST
All reviewed patches have been landed.  Closing bug.
Comment 30 Chris Dumez 2018-01-31 14:59:54 PST
*** Bug 178940 has been marked as a duplicate of this bug. ***
Comment 31 Radar WebKit Bug Importer 2018-01-31 15:00:34 PST
<rdar://problem/37088833>