Bug 181172 – Identify MessagePorts by a globally unique MessagePortIdentifier

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brady Eidson]

Identify MessagePorts by a globally unique MessagePortIdentifier

"Globally unique" in this context means that no matter which process a MessagePort is originally created in, its identifier is guaranteed to not conflict with a port created in any other process. See https://bugs.webkit.org/show_bug.cgi?id=181155 for the precursor to this.

This is the final refactor necessary before WK2 multi-process MessagePorts.

[Brady Eidson]

Created attachment 330255 [details]
Patch

[Alex Christensen]

Comment on attachment 330255 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330255&action=review

> Source/WebCore/dom/MessagePortIdentifier.h:76
> +    unsigned hashes[2];
> +    hashes[0] = WTF::intHash(processIdentifier.toUInt64());
> +    hashes[1] = WTF::intHash(portIdentifier.toUInt64());
> +
> +    return StringHasher::hashMemory(hashes, sizeof(hashes));

Could this use Darin's new computeHash?  See https://bugs.webkit.org/show_bug.cgi?id=180318

[Brady Eidson]

Created attachment 330329 [details]
PFL

[EWS Watchlist]

Comment on attachment 330329 [details]
PFL

Attachment 330329 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/5895383

New failing tests:
imported/w3c/web-platform-tests/service-workers/service-worker/update-after-navigation-fetch-event.https.html

[EWS Watchlist]

Created attachment 330332 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[Brady Eidson]

(In reply to Build Bot from comment #4)
> Comment on attachment 330329 [details]
> PFL
> 
> Attachment 330329 [details] did not pass ios-sim-ews (ios-simulator-wk2):
> Output: http://webkit-queues.webkit.org/results/5895383
> 
> New failing tests:
> imported/w3c/web-platform-tests/service-workers/service-worker/update-after-
> navigation-fetch-event.https.html

Hmmmmm not caused by this patch.

[WebKit Commit Bot]

Comment on attachment 330329 [details]
PFL

Clearing flags on attachment: 330329

Committed r226336: <https://trac.webkit.org/changeset/226336>

[Radar WebKit Bug Importer]

<rdar://problem/36387284>