Bug 181163 - REGRESSION(r226269): 60 JSC test failures on ARMv7
Summary: REGRESSION(r226269): 60 JSC test failures on ARMv7
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks: 108645
  Show dependency treegraph
 
Reported: 2017-12-26 09:06 PST by Zan Dobersek
Modified: 2018-01-02 13:17 PST (History)
9 users (show)

See Also:


Attachments
Patch (1.85 KB, patch)
2017-12-26 09:12 PST, Zan Dobersek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2017-12-26 09:06:31 PST
REGRESSION(r226269): 60 JSC test failures on ARMv7
Comment 1 Zan Dobersek 2017-12-26 09:12:09 PST
Created attachment 330197 [details]
Patch
Comment 2 Yusuke Suzuki 2017-12-26 09:17:49 PST
Comment on attachment 330197 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330197&action=review

Oops, right. Thank you.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:4896
> +        JSValueRegsTemporary result(this);

Right. Previous code uses GPRTemporary, not GPRFlushedCallResult.
Comment 3 WebKit Commit Bot 2017-12-26 10:54:41 PST
Comment on attachment 330197 [details]
Patch

Clearing flags on attachment: 330197

Committed r226294: <https://trac.webkit.org/changeset/226294>
Comment 4 WebKit Commit Bot 2017-12-26 10:54:43 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-01-02 13:17:55 PST
<rdar://problem/36261348>