Bug 181004 – [Meta][Win] Support ICU 59.1+

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Don Olmstead]

ICU 59 changed the value of UChar from wchar_t to char16_t. This causes a number of compilation issues when building on Windows.

https://bugs.webkit.org/show_bug.cgi?id=172729 started the migration but it does not handle all cases for Windows ports.

[Fujii Hironori]

Created attachment 333357 [details]
WIP patch

This is a half-baked WIP patch.
We need a lot of conversions between UChar* and wchar_t*.
I think this is a bad idea.

wchar_t and char16_t has the identical internal representation in Windows.
I think we should define -DUCHAR_TYPE=wchar_t for Windows port.

http://icu-project.org/apiref/icu4c/umachine_8h.html#a6bb9fad572d65b305324ef288165e2ac

[Fujii Hironori]

Created attachment 333359 [details]
Patch

[Don Olmstead]

(In reply to Fujii Hironori from comment #2)
> Created attachment 333359 [details]
> Patch

Does this require ICU to be compiled with that option as well?

[Don Olmstead]

(In reply to Don Olmstead from comment #3)
> (In reply to Fujii Hironori from comment #2)
> > Created attachment 333359 [details]
> > Patch
> 
> Does this require ICU to be compiled with that option as well?

I'll cq+ it if you can confirm whether or not this is the case Fujii

[Fujii Hironori]

(In reply to Don Olmstead from comment #3)
> Does this require ICU to be compiled with that option as well?

No, it doesn't.

[Don Olmstead]

(In reply to Fujii Hironori from comment #5)
> (In reply to Don Olmstead from comment #3)
> > Does this require ICU to be compiled with that option as well?
> 
> No, it doesn't.

Ok cq+ on it. I still think we need to figure out what we should be doing for this though to actually fix it. I'm not sure that this will be available for an extended period of time.

[WebKit Commit Bot]

Comment on attachment 333359 [details]
Patch

Clearing flags on attachment: 333359

Committed r228305: <https://trac.webkit.org/changeset/228305>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/37374476>