Bug 180963 – [Win] Use WCharStringExtras functions in WebCore

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Don Olmstead]

Currently WinCairo cannot compile with ICU 59.1+ as it changed UChar to be char16_t. WCharStringExtras should be used to work around this.

FileSystem related functionality has a lot of compile errors around this.

[Don Olmstead]

Have most of the things converted over to use WCharStringExtras. The thing I'm wondering is whether I should be using StringVectors or wchar_t[] when interacting with the Windows API.

https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/win/FileSystemWin.cpp#L152 uses StringVector

https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/win/FileSystemWin.cpp#L378 uses wchar_t

Happy to modernize anything while hanging out in this file as well.

[Don Olmstead]

Changing to just fix instances where WCharStringExtras can be used in WebCore.

[Don Olmstead]

Created attachment 329848 [details]
Patch

Just uses whats in WCharStringExtras. WebCore does not totally compile but its a start of it.

[EWS Watchlist]

Attachment 329848 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/win/PasteboardWin.cpp:963:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/win/DragImageWin.cpp:78:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 2 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 329848 [details]
Patch

Attachment 329848 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5762607

New failing tests:
fast/mediastream/MediaStream-MediaElement-setObject-null.html

[EWS Watchlist]

Created attachment 329862 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Don Olmstead]

Created attachment 329874 [details]
Patch

[EWS Watchlist]

Attachment 329874 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/win/PasteboardWin.cpp:963:  Tab found; better to use spaces  [whitespace/tab] [1]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Don Olmstead]

Created attachment 329885 [details]
Patch

Fix style

[EWS Watchlist]

Attachment 329885 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Don Olmstead]

Created attachment 329886 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 329886 [details]
Patch

Clearing flags on attachment: 329886

Committed r226205: <https://trac.webkit.org/changeset/226205>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/36168339>