Bug 180794 – WebsiteDataStore::defaultDataStoreConfiguration() fails to set default value for serviceWorkerRegistrationDirectory

• Status: RESOLVED
• Resolution: FIXED
• Component: Service Workers

[Chris Dumez]

Add SPI to set the service worker registration directory to _WKWebsiteDataStoreConfiguration, similarly to what we do for IndexedDB.

[Chris Dumez]

<rdar://problem/36034667>

[Chris Dumez]

Created attachment 329310 [details]
Patch

[Geoffrey Garen]

Comment on attachment 329310 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329310&action=review

r=me

> Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h:42
>  @property (nonatomic, copy, setter=_setWebStorageDirectory:) NSURL *_webStorageDirectory;
>  @property (nonatomic, copy, setter=_setIndexedDBDatabaseDirectory:) NSURL *_indexedDBDatabaseDirectory;
> +@property (nonatomic, copy, setter=_setServiceWorkerRegistrationDirectory:) NSURL *_serviceWorkerRegistrationDirectory WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
>  @property (nonatomic, copy, setter=_setWebSQLDatabaseDirectory:) NSURL *_webSQLDatabaseDirectory;
>  @property (nonatomic, copy, setter=_setCookieStorageFile:) NSURL *_cookieStorageFile;
>  @property (nonatomic, copy, setter=_setResourceLoadStatisticsDirectory:) NSURL *_resourceLoadStatisticsDirectory WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));

Seems kinda crazy that we require the client to set these separately for correct behavior.

[Chris Dumez]

(In reply to Geoffrey Garen from comment #3)
> Comment on attachment 329310 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=329310&action=review
> 
> r=me
> 
> > Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h:42
> >  @property (nonatomic, copy, setter=_setWebStorageDirectory:) NSURL *_webStorageDirectory;
> >  @property (nonatomic, copy, setter=_setIndexedDBDatabaseDirectory:) NSURL *_indexedDBDatabaseDirectory;
> > +@property (nonatomic, copy, setter=_setServiceWorkerRegistrationDirectory:) NSURL *_serviceWorkerRegistrationDirectory WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
> >  @property (nonatomic, copy, setter=_setWebSQLDatabaseDirectory:) NSURL *_webSQLDatabaseDirectory;
> >  @property (nonatomic, copy, setter=_setCookieStorageFile:) NSURL *_cookieStorageFile;
> >  @property (nonatomic, copy, setter=_setResourceLoadStatisticsDirectory:) NSURL *_resourceLoadStatisticsDirectory WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
> 
> Seems kinda crazy that we require the client to set these separately for
> correct behavior.

Agreed, I may have a better fix. I am currently trying it out.

[Chris Dumez]

Created attachment 329357 [details]
Patch

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[WebKit Commit Bot]

Comment on attachment 329357 [details]
Patch

Clearing flags on attachment: 329357

Committed r225911: <https://trac.webkit.org/changeset/225911>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/36052798>