Bug 180784 - StorageProcess::deleteWebsiteData() should ensure there is a SWServer for the given sessionID
Summary: StorageProcess::deleteWebsiteData() should ensure there is a SWServer for the...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-13 16:40 PST by Chris Dumez
Modified: 2017-12-14 11:14 PST (History)
5 users (show)

See Also:

Attachments
Patch (4.49 KB, patch)
2017-12-13 16:42 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (2.81 KB, patch)
2017-12-13 16:45 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-12-13 16:40:35 PST 
StorageProcess::deleteWebsiteData() should ensure there is a SWServer for the given sessionID instead of not clearing anything when no such SWServer exists.
Comment 1 Chris Dumez 2017-12-13 16:42:13 PST 
Created attachment 329284 [details]
Patch
Comment 2 Chris Dumez 2017-12-13 16:45:08 PST 
Created attachment 329285 [details]
Patch
Comment 3 Chris Dumez 2017-12-14 09:03:46 PST 
Work towards <rdar://problem/36034667>.
Comment 4 youenn fablet 2017-12-14 10:51:14 PST 
Comment on attachment 329285 [details]
Patch

I guess we could try to write an API test for this one somehow. Probably need to require filling some service worker, hence the need for an HTTP server...
Comment 5 Chris Dumez 2017-12-14 10:52:37 PST 
(In reply to youenn fablet from comment #4)
> Comment on attachment 329285 [details]
> Patch
> 
> I guess we could try to write an API test for this one somehow. Probably
> need to require filling some service worker, hence the need for an HTTP
> server...

I hear Brady is working on allowing API testing of Service Workers. Once his work lands, I'll look into testing this.
Comment 6 WebKit Commit Bot 2017-12-14 11:14:00 PST 
Comment on attachment 329285 [details]
Patch

Clearing flags on attachment: 329285

Committed r225914: <https://trac.webkit.org/changeset/225914>
Comment 7 WebKit Commit Bot 2017-12-14 11:14:02 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-12-14 11:14:32 PST 
<rdar://problem/36052966>