Bug 180608 - [WPE] Add API version to library soname and pkg-config files
Summary: [WPE] Add API version to library soname and pkg-config files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks: 178894 179915
  Show dependency tree / graph
 
Reported: 2017-12-08 14:32 PST by Michael Catanzaro
Modified: 2018-04-11 06:26 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.56 KB, patch)
2017-12-08 14:33 PST, Michael Catanzaro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2017-12-08 14:32:37 PST 
Add API version to library soname and pkg-config files
Comment 1 Michael Catanzaro 2017-12-08 14:33:36 PST 
Created attachment 328871 [details]
Patch
Comment 2 Michael Catanzaro 2017-12-08 14:37:18 PST 
(No r? because it's not properly tested yet.)
Comment 3 Michael Catanzaro 2018-02-15 10:53:44 PST 
* The include directory for public headers is already versioned

* I don't think the libexecdir for installed processes is versioned, need to confirm and fix
Comment 4 Michael Catanzaro 2018-04-06 16:37:50 PDT 
(In reply to Michael Catanzaro from comment #3)
> * I don't think the libexecdir for installed processes is versioned, need to
> confirm and fix

Even better, the secondary processes are being installed into /usr/bin... I'll handle that in a separate bug.
Comment 5 WebKit Commit Bot 2018-04-09 13:03:54 PDT 
Comment on attachment 328871 [details]
Patch

Clearing flags on attachment: 328871

Committed r230449: <https://trac.webkit.org/changeset/230449>
Comment 6 WebKit Commit Bot 2018-04-09 13:03:56 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Carlos Alberto Lopez Perez 2018-04-11 06:26:54 PDT 
(In reply to WebKit Commit Bot from comment #5)
> Comment on attachment 328871 [details]
> Patch
> 
> Clearing flags on attachment: 328871
> 
> Committed r230449: <https://trac.webkit.org/changeset/230449>

This broke the run-minibrowser script for wpe. Hope we can improve testing things in the future. A fix for this is already in bug 184357