Bug 180467 - Web Inspector: Style Redesign: filtering removes header if one rule has no match even if others do
Summary: Web Inspector: Style Redesign: filtering removes header if one rule has no ma...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on: 180466
Blocks:
  Show dependency tree / graph
 
Reported: 2017-12-06 00:54 PST by Devin Rousso
Modified: 2017-12-06 16:18 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.59 KB, patch)
2017-12-06 01:01 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (2.69 KB, patch)
2017-12-06 11:29 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2017-12-06 00:54:38 PST 
In the case that multiple rules are inherited, if at least one of these rules has no match to the filtered text, the header is hidden, even if other rules do have a match.
Comment 1 Devin Rousso 2017-12-06 01:01:31 PST 
Created attachment 328559 [details]
Patch
Comment 2 Devin Rousso 2017-12-06 11:29:17 PST 
Created attachment 328600 [details]
Patch

Rebase
Comment 3 WebKit Commit Bot 2017-12-06 15:04:34 PST 
Comment on attachment 328600 [details]
Patch

Clearing flags on attachment: 328600

Committed r225600: <https://trac.webkit.org/changeset/225600>
Comment 4 WebKit Commit Bot 2017-12-06 15:04:36 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-12-06 16:18:51 PST 
<rdar://problem/35895756>