Bug 180466 - Web Inspector: REGRESSION(r225569): CSSStyleDetailsSidebarPanel no longer exists
Summary: Web Inspector: REGRESSION(r225569): CSSStyleDetailsSidebarPanel no longer exists
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on: 174229 178331
Blocks: 180467
  Show dependency tree / graph
 
Reported: 2017-12-06 00:12 PST by Devin Rousso
Modified: 2017-12-06 16:22 PST (History)
5 users (show)

See Also:

Attachments
Patch (6.69 KB, patch)
2017-12-06 00:14 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (6.60 KB, patch)
2017-12-06 00:55 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2017-12-06 00:12:28 PST 
r225547 (<https://webkit.org/b/174229> Web Inspector: Styles: make Computed a top-level sidebar tab) renamed CSSStyleDetailsSidebarPanel to GeneralStyleDetailsSidebarPanel.  I didn't notice this when I committed r225569 (<https://webkit.org/b/178331> Web Inspector: [PARITY] Styles Redesign: Make filtering work).  Sorry 😅
Comment 1 Devin Rousso 2017-12-06 00:14:59 PST 
Created attachment 328555 [details]
Patch
Comment 2 Devin Rousso 2017-12-06 00:55:59 PST 
Created attachment 328558 [details]
Patch

Rebase for additional changes
Comment 3 Joseph Pecoraro 2017-12-06 10:18:49 PST 
Comment on attachment 328558 [details]
Patch

rs=me
Comment 4 WebKit Commit Bot 2017-12-06 10:58:44 PST 
Comment on attachment 328558 [details]
Patch

Clearing flags on attachment: 328558

Committed r225580: <https://trac.webkit.org/changeset/225580>
Comment 5 WebKit Commit Bot 2017-12-06 10:58:46 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-12-06 16:22:35 PST 
<rdar://problem/35895854>
Comment 7 Radar WebKit Bug Importer 2017-12-06 16:22:36 PST 
<rdar://problem/35895855>