Bug 180287 – REGRESSION(r221931): Row stretch doesn't work for grid container with min-height

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Javier Fernandez]

Created attachment 328167 [details]
Test case to reproduce the bug

This was working fine before r221931 ( bug #176783 )

Just open the attached example and both grids should have the same output (the item should have 200px height).
However the one with "min-height: 200px" is not stretching.

[Manuel Rego Casasnovas]

Created attachment 328638 [details]
Patch

[EWS Watchlist]

Attachment 328638 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:941:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Manuel Rego Casasnovas]

Created attachment 328643 [details]
Patch

[Manuel Rego Casasnovas]

Created attachment 328647 [details]
Patch

[Darin Adler]

Comment on attachment 328647 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328647&action=review

> Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:944
> +    ASSERT(m_algorithm.freeSpace(direction()));
> +    return m_algorithm.freeSpace(direction()).value();

This assertion isn’t needed. Our version of std::optional::value includes an assertion.

[Manuel Rego Casasnovas]

Comment on attachment 328647 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328647&action=review

Thanks for the review.

>> Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:944
>> +    return m_algorithm.freeSpace(direction()).value();
> 
> This assertion isn’t needed. Our version of std::optional::value includes an assertion.

Ok, removed it.

[Manuel Rego Casasnovas]

Created attachment 328949 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 328949 [details]
Patch for landing

Clearing flags on attachment: 328949

Committed r225741: <https://trac.webkit.org/changeset/225741>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35963250>