Bug 176783 – [css-grid] Stretching auto tracks should be done as part of the track sizing algorithm

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Manuel Rego Casasnovas]

CSS WG has agreed to modify the track sizing algorithm to include a new step: https://drafts.csswg.org/css-grid/#algo-stretch

We used to do the stretch of the "auto" tracks at the end of the track sizing algorithm, however the change integrates this into the algorithm itself as the last step.

See: https://github.com/w3c/csswg-drafts/issues/1150

[Manuel Rego Casasnovas]

Created attachment 320547 [details]
Patch

[Sergio Villar Senin]

Comment on attachment 320547 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320547&action=review

> Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:1077
> +    std::optional<LayoutUnit> currentFreeSpace = freeSpace(m_direction);

auto currentFreeSpace

[Manuel Rego Casasnovas]

Created attachment 320557 [details]
Patch

[Manuel Rego Casasnovas]

Thanks for the review.

(In reply to Sergio Villar Senin from comment #2)
> Comment on attachment 320547 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=320547&action=review
> 
> > Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:1077
> > +    std::optional<LayoutUnit> currentFreeSpace = freeSpace(m_direction);
> 
> auto currentFreeSpace

Ack.

[WebKit Commit Bot]

Comment on attachment 320557 [details]
Patch

Clearing flags on attachment: 320557

Committed r221931: <http://trac.webkit.org/changeset/221931>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/34693473>