Bug 180153 - [Attachment Support] Implement SPI for clients to make an attachment element display in-place
Summary: [Attachment Support] Implement SPI for clients to make an attachment element ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-29 11:06 PST by Wenson Hsieh
Modified: 2017-11-30 09:20 PST (History)
6 users (show)

See Also:

Attachments
First pass (44.57 KB, patch)
2017-11-29 11:54 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Split out AttachmentDisplayOptions into AttachmentTypes.h (50.45 KB, patch)
2017-11-29 12:45 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2017-11-29 11:06:57 PST 
<rdar://problem/35735252>
Comment 1 Wenson Hsieh 2017-11-29 11:54:38 PST 
Created attachment 327882 [details]
First pass
Comment 2 Wenson Hsieh 2017-11-29 12:45:01 PST 
Created attachment 327888 [details]
Split out AttachmentDisplayOptions into AttachmentTypes.h
Comment 3 WebKit Commit Bot 2017-11-29 18:23:48 PST 
Comment on attachment 327888 [details]
Split out AttachmentDisplayOptions into AttachmentTypes.h

Clearing flags on attachment: 327888

Committed r225311: <https://trac.webkit.org/changeset/225311>
Comment 4 WebKit Commit Bot 2017-11-29 18:23:49 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Matt Lewis 2017-11-30 08:44:58 PST 
This caused an API timeout with the API test:
WKAttachmentTests.InPlaceImageAttachmentToggleDisplayMode

on all macOS platforms.

https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK2%20%28Tests%29/builds/1440/steps/run-api-tests/logs/stdio
https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK2%20%28Tests%29/builds/1440
Comment 6 Wenson Hsieh 2017-11-30 09:20:00 PST 
Tracking a fix for the API test in <https://bugs.webkit.org/show_bug.cgi?id=180200>.