Bug 180200 - WKAttachmentTests.InPlaceImageAttachmentToggleDisplayMode times out on macOS bots
Summary: WKAttachmentTests.InPlaceImageAttachmentToggleDisplayMode times out on macOS ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-30 09:18 PST by Wenson Hsieh
Modified: 2017-11-30 10:59 PST (History)
7 users (show)

See Also:

Attachments
Patch (5.14 KB, patch)
2017-11-30 09:40 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2017-11-30 09:18:46 PST 
Test was introduced in r225311.
Comment 1 Wenson Hsieh 2017-11-30 09:40:55 PST 
Created attachment 327983 [details]
Patch
Comment 2 Wenson Hsieh 2017-11-30 09:46:24 PST 
Upon further investigation, the attachment element size seems to differ depending on whether a retina or non-retina display is used, which explains why we only encounter this on the Mac bots.
Comment 3 WebKit Commit Bot 2017-11-30 10:58:09 PST 
Comment on attachment 327983 [details]
Patch

Clearing flags on attachment: 327983

Committed r225332: <https://trac.webkit.org/changeset/225332>
Comment 4 WebKit Commit Bot 2017-11-30 10:58:10 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-11-30 10:59:41 PST 
<rdar://problem/35776711>