Bug 180108 - CodeBlockSet::deleteUnmarkedAndUnreferenced can be a little more efficient
Summary: CodeBlockSet::deleteUnmarkedAndUnreferenced can be a little more efficient
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on:
Blocks: 165909
  Show dependency tree / graph
 
Reported: 2017-11-28 13:48 PST by Filip Pizlo
Modified: 2017-11-29 20:50 PST (History)
6 users (show)

See Also:

Attachments
the patch (3.05 KB, patch)
2017-11-28 13:58 PST, Filip Pizlo 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2017-11-28 13:48:13 PST 
Patch forthcoming.
Comment 1 Filip Pizlo 2017-11-28 13:58:47 PST 
Created attachment 327784 [details]
the patch
Comment 2 Saam Barati 2017-11-28 14:06:08 PST 
Comment on attachment 327784 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327784&action=review

r=me

> Source/JavaScriptCore/heap/CodeBlockSet.cpp:31
> +#include "SuperSampler.h"

You're not using this AFAICT

> Source/JavaScriptCore/heap/CodeBlockSet.cpp:87
> +    // FIXME: make CodeBlock::~CodeBlock a lot faster. It seems insane for that to take 1us or more.

Indeed. That's crazy
Comment 3 Filip Pizlo 2017-11-29 20:49:13 PST 
Landed in https://trac.webkit.org/changeset/225315/webkit
Comment 4 Radar WebKit Bug Importer 2017-11-29 20:50:35 PST 
<rdar://problem/35765296>