Bug 180004 – REGRESSION(r225098): [WPE] Some features have changed of value (70 new failures)

• Status: RESOLVED
• Resolution: FIXED
• Component: WPE WebKit

[Carlos Alberto Lopez Perez]

Like it happened for WebKitGTK+ on bug 179989 this has also happened for WPE

This is the diff http://sprunge.us/TIaX?diff

[Carlos Alberto Lopez Perez]

Committed r225134: <https://trac.webkit.org/changeset/225134>

[Carlos Alberto Lopez Perez]

(In reply to Carlos Alberto Lopez Perez from comment #1)
> Committed r225134: <https://trac.webkit.org/changeset/225134>

The above is a gardening commit. This change on defaults causede 70 new failures (now marked on the expectations file)

[Michael Catanzaro]

I would reenable WebGL2 and EME tests on the bots. In OptionsWPE.cmake:

# Public options shared with other WebKit ports. Do not add any options here
# without approval from a WPE reviewer. There must be strong reason to support
# changing the value of the option.
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ACCELERATED_2D_CANVAS PUBLIC OFF)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ENCRYPTED_MEDIA PUBLIC ${ENABLE_EXPERIMENTAL_FEATURES})

and:

# FIXME: Should ENABLE_USERSELECT_ALL really be turned off?
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_USERSELECT_ALL PRIVATE OFF)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEBGL2 PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})

then remove the corresponding expectations. Then the tests should start passing once the WebKit admins return from Thanksgiving holidays and restart the buildbot master for us (hopefully Monday).

[Michael Catanzaro]

I'll implement my suggestion in comment #3.

[Michael Catanzaro]

Created attachment 327640 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 327640 [details]
Patch

Clearing flags on attachment: 327640

Committed r225219: <https://trac.webkit.org/changeset/225219>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.