Bug 179889 - [WPE] Disable ACCELERATED_2D_CANVAS in FeatureList.pm
Summary: [WPE] Disable ACCELERATED_2D_CANVAS in FeatureList.pm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks: 178894
  Show dependency tree / graph
 
Reported: 2017-11-20 10:11 PST by Michael Catanzaro
Modified: 2017-11-20 18:24 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.51 KB, patch)
2017-11-20 10:12 PST, Michael Catanzaro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2017-11-20 10:11:00 PST 
ACCELERATED_2D_CANVAS is disabled by default for WPE, but turned on in FeatureList.pm. This is bad because it means we are testing a non-default configuration on our bots. Sometimes that's what we actually want to do, but in this case it seems like a bad idea.
Comment 1 Michael Catanzaro 2017-11-20 10:12:41 PST 
Created attachment 327367 [details]
Patch
Comment 2 Michael Catanzaro 2017-11-20 10:12:55 PST 
Note: this could affect layout test results.
Comment 3 WebKit Commit Bot 2017-11-20 17:25:54 PST 
Comment on attachment 327367 [details]
Patch

Clearing flags on attachment: 327367

Committed r225060: <https://trac.webkit.org/changeset/225060>
Comment 4 WebKit Commit Bot 2017-11-20 17:25:55 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Michael Catanzaro 2017-11-20 18:24:03 PST 
(In reply to Michael Catanzaro from comment #2)
> Note: this could affect layout test results.

All tests passed \o/