Bug 179778 - LayoutTest http/tests/workers/service/registration-clear-redundant-worker.html is a flaky failure
Summary: LayoutTest http/tests/workers/service/registration-clear-redundant-worker.htm...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-16 09:37 PST by Ryan Haddad
Modified: 2017-11-29 18:33 PST (History)
6 users (show)

See Also:

Attachments
Patch (4.24 KB, patch)
2017-11-29 16:53 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (4.32 KB, patch)
2017-11-29 16:53 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2017-11-16 09:37:49 PST 
LayoutTest http/tests/workers/service/registration-clear-redundant-worker.html is a flaky failure

https://build.webkit.org/results/Apple%20El%20Capitan%20Release%20WK2%20(Tests)/r224920%20(6022)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fworkers%2Fservice%2Fregistration-clear-redundant-worker.html

--- /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/http/tests/workers/service/registration-clear-redundant-worker-expected.txt
+++ /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/http/tests/workers/service/registration-clear-redundant-worker-actual.txt
@@ -2,5 +2,5 @@
 PASS: Worker became redundant after unregistering
 PASS: registration.installing is null
 PASS: registration.waiting is null
-PASS: registration.active is null
+FAIL: registration.active should be null
Comment 1 Ryan Haddad 2017-11-16 09:38:14 PST 
This test was added with https://trac.webkit.org/changeset/224710/webkit
Comment 2 Chris Dumez 2017-11-16 09:38:58 PST 
Ok, will take a look.
Comment 4 Ryan Haddad 2017-11-29 16:39:32 PST 
Marked test as flaky in https://trac.webkit.org/changeset/225304/webkit
Comment 5 Chris Dumez 2017-11-29 16:40:42 PST 
(In reply to Ryan Haddad from comment #4)
> Marked test as flaky in https://trac.webkit.org/changeset/225304/webkit

Ok, I'll take another look then.
Comment 6 Chris Dumez 2017-11-29 16:44:36 PST 
Was able to reproduce like so:
Tools/Scripts/run-webkit-tests --repeat-each=100 http/tests/workers/service/registration-clear-redundant-worker.html -f
Comment 7 Chris Dumez 2017-11-29 16:53:01 PST 
Created attachment 327927 [details]
Patch
Comment 8 Chris Dumez 2017-11-29 16:53:52 PST 
Created attachment 327928 [details]
Patch
Comment 9 youenn fablet 2017-11-29 16:58:59 PST 
Comment on attachment 327928 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327928&action=review

> LayoutTests/http/tests/workers/service/registration-clear-redundant-worker.html:28
> +                handle = setInterval(function() {

Maybe we could add a limit to the number of retries to allow gracefully failing instead of timing out.
Something like 100 tries every 10 ms for instance.
Comment 10 WebKit Commit Bot 2017-11-29 18:31:47 PST 
Comment on attachment 327928 [details]
Patch

Clearing flags on attachment: 327928

Committed r225312: <https://trac.webkit.org/changeset/225312>
Comment 11 WebKit Commit Bot 2017-11-29 18:31:48 PST 
All reviewed patches have been landed.  Closing bug.
Comment 12 Radar WebKit Bug Importer 2017-11-29 18:33:06 PST 
<rdar://problem/35763630>