Bug 179751 - Dispatching an event on a ServiceWorkerRegistration may fail or crash due to GC
Summary: Dispatching an event on a ServiceWorkerRegistration may fail or crash due to GC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-15 17:14 PST by Chris Dumez
Modified: 2017-11-16 16:47 PST (History)
9 users (show)

See Also:

Attachments
Patch (11.60 KB, patch)
2017-11-15 17:20 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (10.97 KB, patch)
2017-11-16 10:26 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (12.10 KB, patch)
2017-11-16 10:59 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-11-15 17:14:05 PST 
Dispatching an event on a ServiceWorkerRegistration may fail or crash due to GC. We need to make sure that a ServiceWorkerRegistration's wrapper stays alive as long as we may dispatch events on it.
Comment 1 Chris Dumez 2017-11-15 17:20:18 PST 
Created attachment 327038 [details]
Patch
Comment 2 Chris Dumez 2017-11-16 10:26:17 PST 
Created attachment 327079 [details]
Patch
Comment 3 Chris Dumez 2017-11-16 10:59:20 PST 
Created attachment 327085 [details]
Patch
Comment 4 Geoffrey Garen 2017-11-16 16:43:35 PST 
Comment on attachment 327085 [details]
Patch

r=me
Comment 5 Chris Dumez 2017-11-16 16:45:11 PST 
Comment on attachment 327085 [details]
Patch

Clearing flags on attachment: 327085

Committed r224944: <https://trac.webkit.org/changeset/224944>
Comment 6 Chris Dumez 2017-11-16 16:45:12 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-11-16 16:47:14 PST 
<rdar://problem/35603518>